implement feedback; reset polly test

ro-i · ro-i · commit 459c008ccabf · 2025-08-06T07:17:44.000-05:00
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
@@ -9678,8 +9678,7 @@ This instruction requires several arguments:
    indicates the function accepts a variable number of arguments, the
    extra arguments can be specified.
 #. '``fallthrough label``': the label reached when the inline assembly's
-   execution exits the bottom. In case of an intrinsic call, the semantic
-   depends on the semantic of the intrinsic.
+   execution exits the bottom / the intrinsic call terminates.
 #. '``indirect labels``': the labels reached when a callee transfers control
    to a location other than the '``fallthrough label``'. Label constraints
    refer to these destinations.
@@ -9697,7 +9696,7 @@ flow goes after the call.
 The output values of a '``callbr``' instruction are available both in the
 the '``fallthrough``' block, and any '``indirect``' blocks(s).
 
-The only uses of this today are:
+The only current uses of this are:
 
 #. implement the "goto" feature of gcc inline assembly where additional
    labels can be provided as locations for the inline assembly to jump to.
diff --git a/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp b/llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
@@ -3037,16 +3037,16 @@ bool IRTranslator::translateCallBr(const User &U,
   // FIXME: inline asm not yet supported for callbr in GlobalISel As soon as we
   // add support, we need to handle the indirect asm targets, see
   // SelectionDAGBuilder::visitCallBr().
+  Intrinsic::ID IID = I.getIntrinsicID();
   if (I.isInlineAsm())
     return false;
-  if (I.getIntrinsicID() == Intrinsic::not_intrinsic)
+  if (IID == Intrinsic::not_intrinsic)
     return false;
-  if (!translateTargetIntrinsic(I, I.getIntrinsicID(), MIRBuilder))
+  if (!translateTargetIntrinsic(I, IID, MIRBuilder))
     return false;
 
   // Retrieve successors.
-  SmallPtrSet<BasicBlock *, 8> Dests;
-  Dests.insert(I.getDefaultDest());
+  SmallPtrSet<BasicBlock *, 8> Dests = {I.getDefaultDest()};
   MachineBasicBlock *Return = &getMBB(*I.getDefaultDest());
 
   // Update successor info.
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -5422,17 +5422,11 @@ SDVTList SelectionDAGBuilder::getTargetIntrinsicVTList(const CallBase &I,
 SDValue SelectionDAGBuilder::getTargetNonMemIntrinsicNode(
     const CallBase &I, bool HasChain, SmallVector<SDValue, 8> &Ops,
     SDVTList &VTs) {
-  SDValue Result;
-
-  if (!HasChain) {
-    Result = DAG.getNode(ISD::INTRINSIC_WO_CHAIN, getCurSDLoc(), VTs, Ops);
-  } else if (!I.getType()->isVoidTy()) {
-    Result = DAG.getNode(ISD::INTRINSIC_W_CHAIN, getCurSDLoc(), VTs, Ops);
-  } else {
-    Result = DAG.getNode(ISD::INTRINSIC_VOID, getCurSDLoc(), VTs, Ops);
-  }
-
-  return Result;
+  if (!HasChain)
+    return DAG.getNode(ISD::INTRINSIC_WO_CHAIN, getCurSDLoc(), VTs, Ops);
+  if (!I.getType()->isVoidTy())
+    return DAG.getNode(ISD::INTRINSIC_W_CHAIN, getCurSDLoc(), VTs, Ops);
+  return DAG.getNode(ISD::INTRINSIC_VOID, getCurSDLoc(), VTs, Ops);
 }
 
 /// Set root, convert return type if necessaey and check alignment.
diff --git a/llvm/test/Verifier/callbr-intrinsic.ll b/llvm/test/Verifier/callbr-intrinsic.ll
@@ -0,0 +1,57 @@
+; RUN: not opt -S %s -passes=verify 2>&1 | FileCheck %s
+
+declare void @llvm.amdgcn.kill(i1)
+
+; CHECK: Callbr amdgcn_kill only supports one indirect dest
+define void @test_callbr_intrinsic_indirect0(i1 %c) {
+  callbr void @llvm.amdgcn.kill(i1 %c) to label %cont []
+kill:
+  unreachable
+cont:
+  ret void
+}
+
+; CHECK-NEXT: Callbr amdgcn_kill only supports one indirect dest
+define void @test_callbr_intrinsic_indirect2(i1 %c) {
+  callbr void @llvm.amdgcn.kill(i1 %c) to label %cont [label %kill1, label %kill2]
+kill1:
+  unreachable
+kill2:
+  unreachable
+cont:
+  ret void
+}
+
+; CHECK-NEXT: Callbr amdgcn_kill indirect dest needs to be unreachable
+define void @test_callbr_intrinsic_no_unreachable(i1 %c) {
+  callbr void @llvm.amdgcn.kill(i1 %c) to label %cont [label %kill]
+kill:
+  ret void
+cont:
+  ret void
+}
+
+; CHECK-NEXT: Callbr currently only supports asm-goto and selected intrinsics
+declare i32 @llvm.amdgcn.workitem.id.x()
+define void @test_callbr_intrinsic_unsupported() {
+  callbr i32 @llvm.amdgcn.workitem.id.x() to label %cont []
+cont:
+  ret void
+}
+
+; CHECK-NEXT: Callbr: indirect function / invalid signature
+define void @test_callbr_intrinsic_wrong_signature(ptr %ptr) {
+  %func = load ptr, ptr %ptr, align 8
+  callbr void %func() to label %cont []
+cont:
+  ret void
+}
+
+; CHECK-NEXT: Callbr for intrinsics currently doesn't support operand bundles
+define void @test_callbr_intrinsic_no_operand_bundles(i1 %c) {
+  callbr void @llvm.amdgcn.kill(i1 %c) [ "foo"(i1 %c) ] to label %cont [label %kill]
+kill:
+  unreachable
+cont:
+  ret void
+}
diff --git a/llvm/test/Verifier/callbr.ll b/llvm/test/Verifier/callbr.ll
@@ -120,59 +120,3 @@ landingpad:
   %out = call i32 @llvm.callbr.landingpad.i32(i32 %0)
   ret i32 %out
 }
-
-declare void @llvm.amdgcn.kill(i1)
-
-; CHECK-NEXT: Callbr amdgcn_kill only supports one indirect dest
-define void @test_callbr_intrinsic_indirect0(i1 %c) {
-  callbr void @llvm.amdgcn.kill(i1 %c) to label %cont []
-kill:
-  unreachable
-cont:
-  ret void
-}
-
-; CHECK-NEXT: Callbr amdgcn_kill only supports one indirect dest
-define void @test_callbr_intrinsic_indirect2(i1 %c) {
-  callbr void @llvm.amdgcn.kill(i1 %c) to label %cont [label %kill1, label %kill2]
-kill1:
-  unreachable
-kill2:
-  unreachable
-cont:
-  ret void
-}
-
-; CHECK-NEXT: Callbr amdgcn_kill indirect dest needs to be unreachable
-define void @test_callbr_intrinsic_no_unreachable(i1 %c) {
-  callbr void @llvm.amdgcn.kill(i1 %c) to label %cont [label %kill]
-kill:
-  ret void
-cont:
-  ret void
-}
-
-; CHECK-NEXT: Callbr currently only supports asm-goto and selected intrinsics
-declare i32 @llvm.amdgcn.workitem.id.x()
-define void @test_callbr_intrinsic_unsupported() {
-  callbr i32 @llvm.amdgcn.workitem.id.x() to label %cont []
-cont:
-  ret void
-}
-
-; CHECK-NEXT: Callbr: indirect function / invalid signature
-define void @test_callbr_intrinsic_wrong_signature(ptr %ptr) {
-  %func = load ptr, ptr %ptr, align 8
-  callbr void %func() to label %cont []
-cont:
-  ret void
-}
-
-; CHECK-NEXT: Callbr for intrinsics currently doesn't support operand bundles
-define void @test_callbr_intrinsic_no_operand_bundles(i1 %c) {
-  callbr void @llvm.amdgcn.kill(i1 %c) [ "foo"(i1 %c) ] to label %cont [label %kill]
-kill:
-  unreachable
-cont:
-  ret void
-}
diff --git a/polly/test/ScopDetect/callbr.ll b/polly/test/ScopDetect/callbr.ll
@@ -1,7 +1,10 @@
-; RUN: opt %loadNPMPolly '-passes=print<polly-detect>' -disable-output < %s 2>&1 | FileCheck %s
+; RUN: opt %loadNPMPolly '-passes=print<polly-detect>' -polly-detect-track-failures -disable-output -pass-remarks-missed=polly-detect < %s 2>&1 | FileCheck %s --check-prefix=REMARK
+; RUN: opt %loadNPMPolly '-passes=print<polly-detect>' -polly-detect-track-failures -disable-output -stats                            < %s 2>&1 | FileCheck %s --check-prefix=STAT
+; REQUIRES: asserts
 
-; CHECK-LABEL: func
-; CHECK-NOT: Valid
+; REMARK: Branch from indirect terminator.
+
+; STAT: 1 polly-detect - Number of rejected regions: Branch from indirect terminator
 
 
 target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
