Remove condition for emitting noreturn suggestion

snarang181 · snarang181 · commit 1c9aa487a25b · 2025-06-29T11:16:08.000-04:00
diff --git a/clang/lib/Sema/SemaDeclAttr.cpp b/clang/lib/Sema/SemaDeclAttr.cpp
@@ -1980,12 +1980,8 @@ void clang::inferNoReturnAttr(Sema &S, const Decl *D) {
       isKnownToAlwaysThrow(FD)) {
     NonConstFD->addAttr(InferredNoReturnAttr::CreateImplicit(S.Context));
 
-    // Conditionally, emit the suggestion warning.
-    if (!Diags.isIgnored(diag::warn_suggest_noreturn_function,
-                         FD->getLocation())) {
-      S.Diag(FD->getLocation(), diag::warn_suggest_noreturn_function)
-          << 0 << FD;
-    }
+    // Emit a diagnostic suggesting the function being marked [[noreturn]]
+    S.Diag(FD->getLocation(), diag::warn_suggest_noreturn_function) << 0 << FD;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1980,12 +1980,8 @@ void clang::inferNoReturnAttr(Sema &S, const Decl *D) {`
`1980`	`1980`	`isKnownToAlwaysThrow(FD)) {`
`1981`	`1981`	`NonConstFD->addAttr(InferredNoReturnAttr::CreateImplicit(S.Context));`
`1982`	`1982`
`1983`		`- // Conditionally, emit the suggestion warning.`
`1984`		`- if (!Diags.isIgnored(diag::warn_suggest_noreturn_function,`
`1985`		`- FD->getLocation())) {`
`1986`		`- S.Diag(FD->getLocation(), diag::warn_suggest_noreturn_function)`
`1987`		`- << 0 << FD;`
`1988`		`- }`
	`1983`	`+ // Emit a diagnostic suggesting the function being marked [[noreturn]]`
	`1984`	`+ S.Diag(FD->getLocation(), diag::warn_suggest_noreturn_function) << 0 << FD;`
`1989`	`1985`	`}`
`1990`	`1986`	`}`
`1991`	`1987`