Skip to content

Commit 9714289

Browse files
committed
Merge branch 'master' of github.com:bbusemeyer/autogenv2
2 parents 372b132 + ec7ec68 commit 9714289

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

TODO.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1-
- [ ] Manage path setup with setup script.
2-
- crystal, properties, pyscf, and qwalk executible names and locations.
1+
- [ ] Model fitting example.
2+
- [ ] How to handle qwfiles better? Interaction between manager and trialfunc is currently not too flexible. For example it depends on kpoints being a list.
3+
- Possible to move the `export_qwalk` into `trialfunc`?
34
- [ ] Bad use case: accidentally putting the same writer for multiple managers
45
will screw up the process because the first time the writer writes, it delares itself 'done'
56
- [ ] Comparable defaults between PySCF and Crystal are not the same.
67
- [ ] Cannot yet do different paths with QMC and crystal because the basis and the orb file needs to be in the same place.
78
- May need to have the crystal manager export the results to the same directory (this means there are redundant files then).
89
- [ ] PySCF Si run in `simple_test` doesn't make any sense.
10+
- [x] Manage path setup with setup script.
11+
- crystal, properties, pyscf, and qwalk executible names and locations.

autorunner.py

+10-1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,14 @@ def add_task(self,exestr):
3535
else:
3636
self.exelines.append("mpirun -n {tnp} {exe}".format(tnp=self.nn*self.np,exe=exestr))
3737

38+
#-------------------------------------
39+
def add_command(self,cmdstr):
40+
''' Accumulate commands that don't get an MPI command.
41+
Args:
42+
cmdstr (str): executible statement. Will be prepended with appropriate mpirun.
43+
'''
44+
self.exelines.append(cmdstr)
45+
3846
#-------------------------------------
3947
def script(self,scriptfile):
4048
''' Dump accumulated commands into a script for another job to run.
@@ -250,9 +258,10 @@ def script(self,scriptfile):
250258
return True
251259

252260
#-------------------------------------
253-
def submit(self,jobname=None):
261+
def submit(self,jobname=None,ppath=None):
254262
''' Submit series of commands.
255263
Note: jobname is not used because it doesn't submit anything.'''
264+
sys.path=ppath+sys.path
256265

257266
if len(self.exelines)==0:
258267
#print(self.__class__.__name__,": All tasks completed or queued.")

dmc.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def check_complete(self):
111111
print("DMC incomplete: Run completed %d blocks, but requires %d."%\
112112
(self.output['total blocks']-self.output['warmup blocks'],self.minblocks))
113113
completed=False
114-
return complete
114+
return completed
115115

116116
#------------------------------------------------
117117
def collect(self,outfile):

manager.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ def __init__(self,writer,runner,creader=None,name='crystal_run',path=None,
168168
else: self.runner=runner
169169

170170
# Internal.
171-
self.crysinpfn=self.name+'.in'
172-
self.propinpfn=self.name+'.prop.in'
171+
self.crysinpfn=self.name
172+
self.propinpfn=self.name+'.prop'
173173
self.crysoutfn=self.crysinpfn+'.o'
174174
self.propoutfn=self.propinpfn+'.o'
175175
self.restarts=0
@@ -617,7 +617,7 @@ def __init__(self,writer,reader,runner=None,trialfunc=None,
617617
self.completed=False
618618
self.scriptfile=None
619619
self.bundle_ready=False
620-
self.infile="%s.%s"%(name,writer.qmc_abr)
620+
self.infile=name
621621
self.outfile="%s.o"%self.infile
622622
# Note: qwfiles stores file names of results, used for exporting trial wave functions.
623623
self.qwfiles={

0 commit comments

Comments
 (0)