Skip to content

Commit 1b78264

Browse files
authored
fix: disconnect reason inconsistent. (#715)
1 parent cf887c6 commit 1b78264

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

lib/src/core/engine.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -991,7 +991,7 @@ class Engine extends Disposable with EventsEmittable<EngineEvent> {
991991
logger.fine('Signal disconnected ${event.reason}');
992992
if (event.reason == DisconnectReason.disconnected && !_isClosed) {
993993
await handleDisconnect(ClientDisconnectReason.signal);
994-
} else {
994+
} else if (event.reason == DisconnectReason.signalingConnectionFailure) {
995995
events.emit(EngineDisconnectedEvent(
996996
reason: event.reason,
997997
));

lib/src/core/room.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ class Room extends DisposableChangeNotifier with EventsEmittable<RoomEvent> {
601601
Future<void> disconnect() async {
602602
if (engine.isClosed &&
603603
engine.connectionState == ConnectionState.disconnected) {
604-
events.emit(RoomDisconnectedEvent(reason: DisconnectReason.unknown));
604+
logger.warning('Engine is already closed');
605605
return;
606606
}
607607
await engine.disconnect();

lib/src/core/signal_client.dart

+1
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ class SignalClient extends Disposable with EventsEmittable<SignalEvent> {
7979

8080
onDispose(() async {
8181
await cleanUp();
82+
await events.cancelAll();
8283
await events.dispose();
8384
if (!kIsWeb && !lkPlatformIsTest()) {
8485
await _connectivitySubscription?.cancel();

0 commit comments

Comments
 (0)