Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature miscalculations (since BMC version) #55

Open
GoogleCodeExporter opened this issue Mar 31, 2015 · 3 comments
Open

Feature miscalculations (since BMC version) #55

GoogleCodeExporter opened this issue Mar 31, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

in statistics/FeatureStatustucs.cpp/EulerNumber(), the code to set the pixel 
value when inverting the image to find the holes is:
cp->pixel(x,y,z).intensity=1;
This does not set the pixel value to anything, so the image is not inverted to 
find the holes.
Its too bad that the pixel() return type is a valid lvalue, and that the 
compiler didn't warn that the statement has no effect (or maybe it did but 
there were too many other warnings that were being ignored).
The code should be:
cp->set(x,y,z,1);
This should be changed in C-chrm trunk and pychrm trunk.
This affects the test results, which requires updating all .sig and .fit test 
files.

Original issue reported on code.google.com by [email protected] on 15 Dec 2012 at 3:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant