fix: correct bucket name (#184)

* fix: correct bucket name

* chore: oops

* fix: make upload coverage execute before sonar

* feat: revert order change

* feat: adjust coverage config

* chore: i don't think we need to do this now.

Author: cofin

.github/workflows/ci.yml

@@ -126,32 +126,34 @@ jobs:
             docs/_build/html
             .pr_number
 
-  upload-test-coverage:
-    runs-on: ubuntu-latest
-    needs:
-      - test
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-python@v5
-        with:
-          python-version: "3.12"
-
-      - name: Download Artifacts
-        uses: actions/download-artifact@v4
-        with:
-          name: coverage-xml
-
-      - name: Combine coverage files
-        run: |
-          python -Im pip install coverage covdefaults
-          python -Im coverage combine
-          python -Im coverage xml -i
-
-      - name: Fix coverage file name
-        run: sed -i "s/home\/runner\/work\/advanced-alchemy\/advanced-alchemy/github\/workspace/g" coverage.xml
-
-      - name: Upload coverage reports to Codecov
-        uses: codecov/codecov-action@v4
-        with:
-          files: coverage.xml
-          token: ${{ secrets.CODECOV_TOKEN }}
+  # upload-test-coverage:
+  #   runs-on: ubuntu-latest
+  #   needs:
+  #     - test
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #     - uses: actions/setup-python@v5
+  #       with:
+  #         python-version: "3.12"
+
+  #     - name: Download Artifacts
+  #       uses: actions/download-artifact@v4
+  #       with:
+  #         name: coverage-xml
+  #         path: coverage.xml
+  #         merge-multiple: true
+
+  #     - name: Combine coverage files
+  #       run: |
+  #         python -Im pip install coverage covdefaults
+  #         python -Im coverage combine
+  #         python -Im coverage xml -i
+
+  #     - name: Fix coverage file name
+  #       run: sed -i "s/home\/runner\/work\/advanced-alchemy\/advanced-alchemy/github\/workspace/g" coverage.xml
+
+  #     - name: Upload coverage reports to Codecov
+  #       uses: codecov/codecov-action@v4
+  #       with:
+  #         files: coverage.xml
+  #         token: ${{ secrets.CODECOV_TOKEN }}