From 814bf78d94e24bab3d8b8e0244ba35a0e5671b0f Mon Sep 17 00:00:00 2001 From: "Fernando J. Iglesias Garcia" Date: Mon, 20 May 2024 06:45:34 +0200 Subject: [PATCH] Install numpy in CI job. Remove build script substituted by CMake. --- .github/workflows/nanobind.yml | 2 +- build_nanobind.sh | 15 --------------- 2 files changed, 1 insertion(+), 16 deletions(-) delete mode 100755 build_nanobind.sh diff --git a/.github/workflows/nanobind.yml b/.github/workflows/nanobind.yml index bb4ea8e..bbcd217 100644 --- a/.github/workflows/nanobind.yml +++ b/.github/workflows/nanobind.yml @@ -23,7 +23,7 @@ jobs: - name: Install dependencies run: | sudo apt-get install -y libarpack2-dev libcxxopts-dev libeigen3-dev libfmt-dev python3.11-dev - python -m pip install nanobind + python -m pip install nanobind numpy - name: Configure run: cmake -B ${{github.workspace}}/build -DBUILD_NANOBIND=ON diff --git a/build_nanobind.sh b/build_nanobind.sh deleted file mode 100755 index 2a672c4..0000000 --- a/build_nanobind.sh +++ /dev/null @@ -1,15 +0,0 @@ -#!/bin/sh - -mkdir -p build/src/python # for the couple of .o files - -# DOC on the options: https://github.com/wjakob/nanobind/blob/master/src/nb_combined.cpp#L30 - -# 17 is from nanobind's doc, does it work welll with others? -# TODO tapkee submmodule or external dependency. -g++ src/python/nanobind_extension.cpp -std=c++17 -fvisibility=hidden -DNDEBUG -DNB_COMPACT_ASSERTIONS -I/usr/include/python3.12 -fPIC -I./include -I./src -I/usr/include/eigen3 -I/home/garcia/coding-challenges/ext/nanobind/include -I~/coding-challenges/ext/nanobind/ext/robin_map/include -Os -c -o build/src/python/nanobind_extension.o - -g++ ~/coding-challenges/ext/nanobind/src/nb_combined.cpp -std=c++17 -fvisibility=hidden -DNDEBUG -DNB_COMPACT_ASSERTIONS -I/usr/include/python3.12 -fPIC -I/home/garcia/coding-challenges/ext/nanobind/include -I/home/garcia/coding-challenges/ext/nanobind/ext/robin_map/include -O3 -fno-strict-aliasing -ffunction-sections -fdata-sections -c -o build/src/python/libnanobind.o - -g++ -shared -Wl,-s -Wl,--gc-sections build/src/python/nanobind_extension.o build/src/python/libnanobind.o -lfmt -o lib/tapkee.cpython-312-x86_64-linux-gnu.so - -PYTHONPATH=. python examples/nanobind.py