Skip to content

Commit 84fc3d7

Browse files
committed
Fix string overflow bug
We used ';' as a second parameter to the string constructor, which is clearly wrong and made the constructor read 59 bytes instead of using the null byte as termination. https://en.cppreference.com/w/cpp/string/basic_string/basic_string Not that it'd be a big deal security wise (the value has never been printed, so this couldn't be used to e.g., read secrets from RAM in CI environments etc.), but it breaks the functionality. Found while looking into #61.
1 parent 04d96e1 commit 84fc3d7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ int main(const int argc, const char *const *const argv) {
136136
std::vector<std::string> extraPluginsFromEnv;
137137
const auto* const extraPluginsFromEnvData = getenv("EXTRA_QT_PLUGINS");
138138
if (extraPluginsFromEnvData != nullptr)
139-
extraPluginsFromEnv = linuxdeploy::util::split(std::string(extraPluginsFromEnvData, ';'));
139+
extraPluginsFromEnv = linuxdeploy::util::split(std::string(extraPluginsFromEnvData), ';');
140140

141141
for (const auto& pluginsList : {static_cast<std::vector<std::string>>(extraPlugins.Get()), extraPluginsFromEnv}) {
142142
std::copy_if(QtModules.begin(), QtModules.end(), std::back_inserter(extraQtModules),

0 commit comments

Comments
 (0)