Skip to content

Commit 021ec07

Browse files
committed
Revert "efi/x86: Set the PE/COFF header's NX compat flag unconditionally"
This reverts commit 891f889. Revert because of compatibility issues of MS Surface devices and GRUB with NX. In short, these devices get stuck on boot with NX advertised. So to not advertise it, add the respective option back in. Signed-off-by: Maximilian Luz <[email protected]> Patchset: secureboot
1 parent d3be061 commit 021ec07

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

arch/x86/boot/header.S

+4
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,11 @@ extra_header_fields:
111111
.long salign # SizeOfHeaders
112112
.long 0 # CheckSum
113113
.word IMAGE_SUBSYSTEM_EFI_APPLICATION # Subsystem (EFI application)
114+
#ifdef CONFIG_EFI_DXE_MEM_ATTRIBUTES
114115
.word IMAGE_DLL_CHARACTERISTICS_NX_COMPAT # DllCharacteristics
116+
#else
117+
.word 0 # DllCharacteristics
118+
#endif
115119
#ifdef CONFIG_X86_32
116120
.long 0 # SizeOfStackReserve
117121
.long 0 # SizeOfStackCommit

0 commit comments

Comments
 (0)