Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid line in hyundai_a7.fex #50

Closed
n1tehawk opened this issue May 16, 2016 · 2 comments
Closed

Invalid line in hyundai_a7.fex #50

n1tehawk opened this issue May 16, 2016 · 2 comments

Comments

@n1tehawk
Copy link
Contributor

n1tehawk commented May 16, 2016

The sunxi-tools FEX compiler chokes on hyundai_a7.fex#L821 with an error message
E: sunxi-boards/sys_config/a10/hyundai_a7.fex:821: invalid character at 1.

That line indeed looks rather wrong, and should probably be removed.

@n1tehawk
Copy link
Contributor Author

n1tehawk commented May 25, 2016

This has resurfaced with xunlong_orange_pi_pc_plus.fex#L357 and xunlong_orange_pi_plus_2e.fex#L357, for which the original .bin files were extracted and decompiled from vendor-provided images.

The .bin files show that these lines actually went into them as <key> = <value> pairs with an unusual / malformed key string, starting with : plus whitespace. Judging from the fact that the keys seem to relate to the section that follows, I get the impression that these originally might have been ; comment = something lines preceding the section, where a typo turned the ; into :.

We probably need to take more care with possibly malformed section entries (e.g. issue a warning) in our sunxi-tools script_bin.c. It might also be desirable to auto-correct this special case into a .fex comment line (by simply reverting to ;), which some sunxi-boards contributors seem to have done manually - compare e.g. xunlong_orange_pi_pc.fex#L359.

@n1tehawk
Copy link
Contributor Author

This has been addressed with an updated version of sunxi-fexc.

Commit linux-sunxi/sunxi-tools@7a0a701 lets the .fex compiler issue a warning on these lines, but apart from that it will accept (and ignore) them. bin2fex will now also warn when decompiling .bin files that lead to the creation of such entries (so they're easier to spot and fix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant