Skip to content

Commit dd2c305

Browse files
committed
Change default polling_interval to 1
This allows mbpfan to react more quickly to changing workloads and avoid CPU throttling. Also change unit test expectations. Fixes #159.
1 parent 50f3a67 commit dd2c305

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

Diff for: mbpfan.conf

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@
1515
low_temp = 63 # try ranges 55-63, default is 63
1616
high_temp = 66 # try ranges 58-66, default is 66
1717
max_temp = 86 # take highest number returned by "cat /sys/devices/platform/coretemp.*/hwmon/hwmon*/temp*_max", divide by 1000
18-
polling_interval = 7 # default is 7 seconds
18+
polling_interval = 1 # default is 1 seconds

Diff for: mbpfan.conf.test0

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ max_fan1_speed = 6200 # put the *highest* value of "cat /sys/devices/platform/ap
55
low_temp = 63 # try ranges 55-63, default is 63
66
high_temp = 66 # try ranges 58-66, default is 66
77
max_temp = 86 # take highest number returned by "cat /sys/devices/platform/coretemp.*/hwmon/hwmon*/temp*_max", divide by 1000
8-
polling_interval = 7 # default is 7 seconds
8+
polling_interval = 7 # default is 1 second

Diff for: mbpfan.conf.test1

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ max_fan1_speed = 6200 # default is 6200
44
low_temp = 63 # try ranges 55-63, default is 63
55
high_temp = 66 # try ranges 58-66, default is 66
66
max_temp = 86 # do not set it > 90, default is 86
7-
polling_interval = 1 # default is 7
7+
polling_interval = 2 # default is 1 second

Diff for: mbpfan.conf.test2

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ min_fan2_speed = 2000 # default is 6200
44
low_temp = 63 # try ranges 55-63, default is 63
55
high_temp = 66 # try ranges 58-66, default is 66
66
max_temp = 86 # do not set it > 90, default is 86
7-
polling_interval = 1 # default is 7
7+
polling_interval = 1 # default is 1 second

Diff for: src/mbpfan.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ int max_temp = 86; // do not set it > 90
6363
#define NUM_MIN_FAN_SPEED_DEFAULT 2000
6464
#define NUM_MAX_FAN_SPEED_DEFAULT 6200
6565

66-
int polling_interval = 7;
66+
int polling_interval = 1;
6767

6868
t_sensors* sensors = NULL;
6969
t_fans* fans = NULL;

Diff for: src/minunit.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ static const char *test_settings()
136136

137137
retrieve_settings("./mbpfan.conf.test1", fan);
138138
mu_assert("max_fan_speed value is not 6200", fan->fan_max_speed == 6200);
139-
mu_assert("polling_interval is not 1", polling_interval == 1);
139+
mu_assert("polling_interval is not 2", polling_interval == 2);
140140

141141
fan->fan_min_speed = -1;
142142
retrieve_settings("./mbpfan.conf.test0", fan);
@@ -200,10 +200,10 @@ static const char *test_settings_reload()
200200
retrieve_settings("./mbpfan.conf", fan);
201201
printf("Testing the _supplied_ mbpfan.conf (not the one you are using)..\n");
202202
// cannot tests min_fan_speed since it is not set and thus auto-detected
203-
mu_assert("polling_interval is not 7 before SIGHUP", polling_interval == 7);
203+
mu_assert("polling_interval is not 1 before SIGHUP", polling_interval == 1);
204204
raise(SIGHUP);
205205
mu_assert("min_fan_speed value is not 6200 after SIGHUP", fan->fan_min_speed == 6200);
206-
mu_assert("polling_interval is not 1 after SIGHUP", polling_interval == 1);
206+
mu_assert("polling_interval is not 2 after SIGHUP", polling_interval == 2);
207207
retrieve_settings("./mbpfan.conf", fan);
208208
free(fan);
209209
return 0;

0 commit comments

Comments
 (0)