Skip to content

Commit 368aed4

Browse files
Add support for firewall rules version and fingerprint (#656)
1 parent 68772a8 commit 368aed4

5 files changed

Lines changed: 23 additions & 7 deletions

File tree

test/fixtures/networking_firewalls.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,16 @@
33
{
44
"id":123,
55
"label":"test-firewall-1",
6-
"created":"2018-01-01T00:01:01",
7-
"updated":"2018-01-01T00:01:01",
6+
"created":"2018-01-01T00:01:03",
7+
"updated":"2018-01-01T00:01:03",
88
"status":"enabled",
99
"rules":{
1010
"outbound":[],
1111
"outbound_policy":"DROP",
1212
"inbound":[],
13-
"inbound_policy":"DROP"
13+
"inbound_policy":"DROP",
14+
"version":2,
15+
"fingerprint":"4ef67a29"
1416
},
1517
"tags":[]
1618
}
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
{
22
"id":123,
33
"label":"test-firewall-1",
4-
"created":"2018-01-01T00:01:01",
5-
"updated":"2018-01-01T00:01:01",
4+
"created":"2018-01-01T00:01:02",
5+
"updated":"2018-01-01T00:01:02",
66
"status":"enabled",
77
"rules":{
88
"outbound":[],
99
"outbound_policy":"DROP",
1010
"inbound":[],
11-
"inbound_policy":"DROP"
11+
"inbound_policy":"DROP",
12+
"version":2,
13+
"fingerprint":"4ef67a29"
1214
},
1315
"tags":[]
1416
}

test/fixtures/networking_firewalls_123_rules.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,7 @@
22
"inbound": [],
33
"inbound_policy": "DROP",
44
"outbound": [],
5-
"outbound_policy": "DROP"
5+
"outbound_policy": "DROP",
6+
"version": 2,
7+
"fingerprint": "4ef67a29"
68
}

test/integration/models/firewall/test_firewall.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ def test_get_firewall_rules(test_linode_client, test_firewall):
2929

3030
assert rules.inbound_policy in ["ACCEPT", "DROP"]
3131
assert rules.outbound_policy in ["ACCEPT", "DROP"]
32+
assert isinstance(rules.version, int)
33+
assert rules.version > 0
34+
assert isinstance(rules.fingerprint, str)
35+
assert len(rules.fingerprint) > 0
3236

3337

3438
@pytest.mark.smoke
@@ -61,6 +65,10 @@ def test_update_firewall_rules(test_linode_client, test_firewall):
6165

6266
assert firewall.rules.inbound_policy == "ACCEPT"
6367
assert firewall.rules.outbound_policy == "DROP"
68+
assert isinstance(firewall.rules.version, int)
69+
assert firewall.rules.version > 0
70+
assert isinstance(firewall.rules.fingerprint, str)
71+
assert len(firewall.rules.fingerprint) > 0
6472

6573

6674
def test_get_devices(test_linode_client, linode_fw, test_firewall):

test/unit/objects/firewall_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ def test_get_rules(self):
2020
self.assertEqual(rules.inbound_policy, "DROP")
2121
self.assertEqual(len(rules.outbound), 0)
2222
self.assertEqual(rules.outbound_policy, "DROP")
23+
self.assertEqual(rules.version, 2)
24+
self.assertEqual(rules.fingerprint, "4ef67a29")
2325

2426
def test_update_rules(self):
2527
"""

0 commit comments

Comments
 (0)