Skip to content

Remove karma command (info is enough) #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove karma command (info is enough) #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd3e9bb
Initial commit with task details for issue #49
konard Sep 14, 2025
306b15e
Remove karma command as requested in issue #49
konard Sep 14, 2025
9b98eb0
Remove CLAUDE.md - Claude command completed
konard Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions python/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
| ✔️ | bottom | Вывести информацию о участниках беседы в порядке увеличения кармы. |
| ✔️ | bottom [ЯЗЫКИ] | Вывести информацию о участниках беседы с указанными языками в порядке увеличения кармы. |
| ✔️ | bottom [ЧИСЛО] | Вывести информацию об указанном числе участников беседы беседы в порядке увеличения кармы. |
| ✔️ | karma | Вывод своей кармы или кармы участника беседы из пересланного сообщения. |
| ⭐ | info | Вывести общую информацию (карма (только для бесед с кармой), добавленные языки, ссылка на профиль github) о себе или участнике беседы из пересланного сообщения. |
| ⭐ | update | Обновить информацию о вас (имя). Эта команда так же выводит информацию о вас как это делает команда info. |
| ✔️ | + | Проголосовать за повышение кармы участника беседы из пересланного сообщения. |
Expand All @@ -41,7 +40,6 @@
| people | люди |
| top | топ | верх |
| bottom | дно | низ |
| karma | карма|
| info | инфо |
| update | обновить |
| what is | что такое |
Expand Down
1 change: 0 additions & 1 deletion python/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def __init__(
lambda: self.commands.change_github_profile(True)),
(patterns.REMOVE_GITHUB_PROFILE,
lambda: self.commands.change_github_profile(False)),
(patterns.KARMA, self.commands.karma_message),
(patterns.TOP, self.commands.top),
(patterns.PEOPLE, self.commands.top),
(patterns.BOTTOM,
Expand Down
8 changes: 0 additions & 8 deletions python/modules/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,6 @@ def change_github_profile(
CommandsBuilder.build_github_profile(self.current_user, self.data_service),
self.peer_id)

def karma_message(self) -> NoReturn:
"""Shows user's karma."""
if self.peer_id < 2e9 and not self.karma_enabled:
return
is_self = self.user.uid == self.from_id
self.vk_instance.send_msg(
CommandsBuilder.build_karma(self.user, self.data_service, is_self),
self.peer_id)

def top(
self,
Expand Down
16 changes: 0 additions & 16 deletions python/modules/commands_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,22 +92,6 @@ def build_github_profile(
return (f"[id{data.get_user_property(user, 'uid')}|{data.get_user_property(user, 'name')}], "
f"Ваша страничка на GitHub — {profile}.")

@staticmethod
def build_karma(
user: BetterUser,
data: BetterBotBaseDataService,
is_self: bool
) -> str:
"""Sends user karma amount.
"""
if is_self:
return (f"[id{data.get_user_property(user, 'uid')}|"
f"{data.get_user_property(user, 'name')}], "
f"Ваша карма — {DataBuilder.build_karma(user, data)}.")
else:
return (f"Карма [id{data.get_user_property(user, 'uid')}|"
f"{data.get_user_property(user, 'name')}] — "
f"{DataBuilder.build_karma(user, data)}.")

@staticmethod
def build_not_enough_karma(
Expand Down
2 changes: 0 additions & 2 deletions python/patterns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
UPDATE = recompile(
r'\A\s*(обновить|update)\s*\Z', IGNORECASE)

KARMA = recompile(
r'\A\s*(карма|karma)\s*\Z', IGNORECASE)

APPLY_KARMA = recompile(
r'\A(\[id(?<selectedUserId>\d+)\|@\w+\])?\s*(?P<operator>\+|\-)(?P<amount>[0-9]*)\s*\Z')
Expand Down
10 changes: 0 additions & 10 deletions python/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,6 @@ def test_change_github_profile(
self.commands.match_command(patterns.REMOVE_GITHUB_PROFILE)
self.commands.change_github_profile(False)

@ordered
def test_karma_message(
self
) -> NoReturn:
self.commands.karma_message()
self.commands.user = db.get_user(2)
self.commands.karma_message()

@ordered
def test_top(
Expand Down Expand Up @@ -203,7 +196,6 @@ def test_apply_user_carma(
self.commands.user = db.get_user(1)
self.commands.apply_user_karma(self.commands.user, 5)
db.save_user(self.commands.user)
self.commands.karma_message()

@ordered
def test_apply_collective_vote(
Expand All @@ -213,14 +205,12 @@ def test_apply_collective_vote(
self.commands.user = db.get_user(1)
self.commands.apply_collective_vote("opponents", config.NEGATIVE_VOTES_PER_KARMA, -1)
db.save_user(self.commands.user)
self.commands.karma_message()

@ordered
def test_apply_karma_change(
self
) -> NoReturn:
self.commands.apply_karma_change('-', 6)
self.commands.karma_message()


if __name__ == '__main__':
Expand Down
Loading