Skip to content

Remove numerical offset usage #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
haoxu07 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove numerical offset usage #2297

haoxu07 wants to merge 1 commit into from

Conversation

@haoxu07
Copy link
Contributor

@haoxu07 haoxu07 commented Nov 18, 2025

Problem Statement

Solution

Code changes

  • Added new code behind a config. If so list the config names and their default values in the PR description.
  • Introduced new log lines.
    • Confirmed if logs need to be rate limited to avoid excessive logging.

Concurrency-Specific Checks

Both reviewer and PR author to verify

  • Code has no race conditions or thread safety issues.
  • Proper synchronization mechanisms (e.g., synchronized, RWLock) are used where needed.
  • No blocking calls inside critical sections that could lead to deadlocks or performance degradation.
  • Verified thread-safe collections are used (e.g., ConcurrentHashMap, CopyOnWriteArrayList).
  • Validated proper exception handling in multi-threaded code to avoid silent thread termination.

How was this PR tested?

  • New unit tests added.
  • New integration tests added.
  • Modified or extended existing tests.
  • Verified backward compatibility (if applicable).

Does this PR introduce any user-facing or breaking changes?

  • No. You can skip the rest of this section.
  • Yes. Clearly explain the behavior change and its impact.

@haoxu07 haoxu07 changed the title Remove numberic offset usage Remove numerical offset usage Nov 18, 2025
@haoxu07 haoxu07 force-pushed the removeNumericOffsetFromAdmin branch from 9f8e33e to 763499b Compare December 1, 2025 11:24
@haoxu07
Complete V1 admin topic metadata removal and fix test failures
f7cce43 
- Remove all V1 methods, constants, and configuration keys
- Fix AdminConsumptionTask to synchronize numeric offsets with positions
- Add automatic offset sync in AdminMetadata.setPubSubPosition()
- Update all tests to use V2 format (AdminMetadata vs Map<String, Long>)
- Add generateAdminMetadata() helper for V2 test data creation
- System now exclusively uses V2 admin topic metadata format

Fixes test failures caused by V1/V2 data format mismatches.
@haoxu07 haoxu07 force-pushed the removeNumericOffsetFromAdmin branch from 763499b to f7cce43 Compare December 2, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@haoxu07