Add bundle and operation counters #4991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Merged
deuszx
reviewed
Nov 19, 2025
linera-core/src/worker.rs
Outdated
| }); | ||
|
|
||
| pub static OPERATION_COUNT: LazyLock<IntCounterVec> = | ||
| LazyLock::new(|| register_int_counter_vec("operation_count", "Operation count", &[])); |
Contributor
There was a problem hiding this comment.
It doesn't need to be a _vec if we don't use labels.
Contributor
Author
There was a problem hiding this comment.
True, but I guess my thinking was: if we one day decide to add labels to this, will Prometheus keep the non-vec historical data logged to the same metric? That's why I've been using _vec everywhere 🤔
It seems actually that adding/removing labels creates an entirely new time series https://prometheus.io/docs/concepts/data_model/?metric-names-and-labels so we might as well drop the _vec
This was referenced Nov 19, 2025
ndr-ds
force-pushed
the
11-17-add_bundle_and_operation_counters
branch
from
4bbb2ed to
59364ff
Compare
This was referenced Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should track operations and messages as well, not just transactions generically
Proposal
Add metrics for operations and messages
Test Plan
Deployed a network with this, saw the metrics
Release Plan