Skip to content

Commit 0246dcf

Browse files
authored
Merge pull request #212 from kazuki-ma/build-fixup
NON-ISSUE: Brash up exec jar creation.
2 parents 68fbb69 + 9fc704a commit 0246dcf

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

line-bot-cli/build.gradle

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,26 @@ dependencies {
2121
compile 'com.google.guava:guava'
2222
}
2323

24-
// Default bootRepackage & signArchives has task dependency issue.
25-
// Manually define new `execBootRepackage` task and make dependency from signArchives to execBootRepackage.
26-
bootRepackage.enabled = false
27-
task execBootRepackage(type: BootRepackage, dependsOn: jar) {
24+
bootRepackage {
2825
enabled = true
2926
executable = true
3027
// Custom Launch Script avoid https://github.com/spring-projects/spring-boot/issues/5164
3128
embeddedLaunchScript = file('src/main/resources/launch.script')
3229
withJarTask = jar
30+
classifier = 'exec'
3331
mainClass = 'com.linecorp.bot.cli.Application'
3432
}
3533

36-
signArchives.dependsOn execBootRepackage
34+
// Reset bootRepackage dependency to remove dependency from bootRepackage to signArchives.
35+
// This causes circular dependency.
36+
//
37+
// Memo: By default, bootRepackage dependsOn the all tasks creating jar including signArchives task.
38+
// But signArchives should be after repackages.
39+
bootRepackage.dependsOn.clear()
40+
bootRepackage.dependsOn jar, findMainClass
41+
signArchives.dependsOn bootRepackage
3742

38-
artifacts {
39-
archives sourcesJar, javadocJar, file("$buildDir/libs/${project.name}-${project.version}.jar")
43+
// Add exec jar into archives to be uploaded.
44+
artifacts.add('archives', file("$buildDir/libs/${project.name}-${project.version}-${bootRepackage.classifier}.jar")) {
45+
classifier = bootRepackage.classifier
4046
}

0 commit comments

Comments
 (0)