New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Automatic-Module-Name for armeria-thrift0.9 #6075

Open

yzfeng2020 opened this issue Jan 22, 2025 · 0 comments · May be fixed by #6076

Contributor

yzfeng2020 commented Jan 22, 2025

The Automatic-Module-Name is invalid for armeria-thrift0.9, as thrift0.9 isn't a valid java identifier.

To repro

> wget https://repo1.maven.org/maven2/com/linecorp/armeria/armeria/1.30.3/armeria-1.30.3.jar
> jar --describe-module --file armeria-thrift0.9-1.30.3.jar

Unable to derive module descriptor for: armeria-thrift0.9-1.30.3.jar
Automatic-Module-Name: com.linecorp.armeria.thrift0.9: Invalid module name: '9' is not a Java identifier

discord link: https://discord.com/channels/1087271586832318494/1087272728177942629/1331497634883702875

The text was updated successfully, but these errors were encountered:

jrhee17 linked a pull request

that will close this issue

Support java modules for thrift #6076

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment