Merge pull request #2892 from alexandear/refactor/useless-copy-loop-var

jandubois · web-flow · commit 243ad9c02168 · 2024-11-11T18:11:15.000-08:00
refactor: remove useless copy loop var
diff --git a/.golangci.yml b/.golangci.yml
@@ -32,6 +32,7 @@ linters:
   - typecheck
   # - asciicheck
   - bodyclose
+  - copyloopvar
   # - dogsled
   # - dupl
   - dupword
diff --git a/pkg/qemu/qemu_driver.go b/pkg/qemu/qemu_driver.go
@@ -131,9 +131,6 @@ func (l *LimaQemuDriver) Start(ctx context.Context) (chan error, error) {
 	}
 
 	for i, vhostCmd := range vhostCmds {
-		i := i
-		vhostCmd := vhostCmd
-
 		logrus.Debugf("vhostCmd[%d].Args: %v", i, vhostCmd.Args)
 		if err := vhostCmd.Start(); err != nil {
 			return nil, err

Original file line number	Diff line number	Diff line change
`@@ -131,9 +131,6 @@ func (l *LimaQemuDriver) Start(ctx context.Context) (chan error, error) {`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`for i, vhostCmd := range vhostCmds {`
`134`		`- i := i`
`135`		`- vhostCmd := vhostCmd`
`136`		`-`
`137`	`134`	`logrus.Debugf("vhostCmd[%d].Args: %v", i, vhostCmd.Args)`
`138`	`135`	`if err := vhostCmd.Start(); err != nil {`
`139`	`136`	`return nil, err`