Discussion about 2.0 release

[alexislefebvre]

Thanks to contributors, a lot of changes have been done in order to prepare a new 2.0 release that will be compatible with Symfony 3.4 and 4.0. #379 was the final step of our initial plan for this new release.

We can now discuss of the remaining changes:

• Documentation: BC changes, guide to migrate to 2.x branch, etc. [2.x] Upgrade guide #382
• Using traits instead of one big class (the big WebTestCase), see Refactor the bundle to be more stable and faster #332 (comment) and Refactor the bundle to be more stable and faster #332 (comment) (I'll try to do it soon but feel free to try by yourself), see [2.0] Reduce size of WebTestCase? #392 and now Separate db tool and db backup/restore services for version 2.x #398
• Introduce changes that break BC before we release the 2.0 version, all changes that will come after this release will have to respect BC, otherwise they will have to go the next major release
• Create a 1.x branch for the legacy version and merge 2.x in master? We don't need to do this today, maybe we could do this after the first alpha release?
• Release the 2.0.0-alpha1 version?
• Add a doc directory and reduce length of README.md ? (see https://github.com/EasyCorp/easy-deploy-bundle#documentation or https://github.com/lexik/LexikFormFilterBundle/blob/master/Resources/doc/index.md for examples)
• Check that examples are up-to-date: https://github.com/liip/LiipFunctionalTestBundle/tree/2.x/ExampleTests, see [2.x]: Remove ExampleTests, move them in documentation #457
• Clean the suggest part in composer.json: outdated reference to Symfony 2.5 and paratest that doesn't work anymore IIRC, see 2.x update composer suggest and upgrade guide #407
• [2.0] Cannot load dependent fixtures that needs dependency injection [2.0] Cannot load dependent fixtures that needs dependency injection #411 → Use SymfonyFixturesLoader to load fixtures #432

Opened Issues and PRs:

• Make classes final? Make classes final? #380

Changes from 1.x that can be ported to 2.x:

• Allow static assertion calls Allow static assertion calls #445
• Use a session name by default Use a session name by default #444 (we need to check it it's applicable to Symfony 3 and 4)

Please add any idea you can think of.

[soullivaneuh]

Using traits instead of one big class

As I said in #332 (comment), I 👍 this! Maybe opening a dedicated issue about that rather than a comment?

Create a 1.x branch for the legacy version and merge 2.x in master? We don't need to do this today, maybe we could do this after the first alpha release?

There are several way to go. Sonata case: Master is for not released next major, then we have branches per major version (and the higher is the maintained one).

Release the 2.0.0-alpha1 version?

Would be a great idea and should be done right now IMHO, because we currently don't have any release supporting Symfony 4 that is already stable from a while now.

Plus, an alpha release still allows to introduce BC break changes, so it won't be a problem for the rest of the work to do.

[alexislefebvre]

I tried to split WebTestCase in several traits and I discovered that traits can't extend a class So some necessary calls to Symfony\Bundle\FrameworkBundle\Test\WebTestCase are broken. I'll investigate further.

[Jean85]

I'm personally against traits. They are simple a dirty way to avoid copy and paste, and I don't think we have many places were we should use it.

Can we investigate in a case-by-case basis? I don't know many of them, and IMHO some features that we are thinking about splitting in traits could be dropped (see Paratest which is no longer mantained and shouldn't need code integration on our side) or forked in a separate class/lib/bundle.

For the 1.x branch, it should be created from the latest 1.x tag just after the 2.x branch gets merged into master, along with a README change that explains the maintaners' position (we only patch 1.x, 2.x/master for new features).

[Jean85]

I started the docs part with #382

[alexislefebvre]

Thanks again @Jean85 and @soullivaneuh, here is the alpha release with your work: https://github.com/liip/LiipFunctionalTestBundle/releases/tag/2.0.0-alpha1

[alexislefebvre]

I tested the 2.0.0-alpha1 on a fresh Symfony 4 project and it worked perfectly. ✅

[Jean85]

Next week I hope to have time to test this on a project with Symfony 3.4 which currently uses the 1.x release.

[soullivaneuh]

@alexislefebvre Same thing here, works like a charm! :-)

[enekochan]

I've tested the 2.0.0-alpha4 in a Symfony 3.4 project (I'm currently updating the production app from Symfony 3.3) and after following the upgrade guide everything worked perfectly :) I'm using cached SQLite and PHPUnit 6.5.8 by the way.

[alexislefebvre]

Hello, I think that we should plan a beta release and a final release in September. Do everyone agree? I think that we won't introduce BC break changes on the 2.x branch.

[wietsewarendorff]

Hi @alexislefebvre , any news on a release date for 2.0? Milestone was due in february, and the comment above mentiones september. I can see there are still some open issues, but also very little progress.

No rush, just looking forward to it since I have to upgrade to phpunit 7 for my current project (and therefore need it) :)

[alexislefebvre]

Tests are broken as of today because of a bug in last releases of Symfony: #447 (comment)

I would like to publish a beta release once this bug will be fixed (nobody complained about my previous comment so they probably agree).

[alexislefebvre]

Tests were still broken after the last release of Symfony (3.4.16), it looks like there's an issue with PHPCR, I removed PHPCR and opened a PR in order to discuss about the removal: #452

[rvanlaak]

As you stated in #452, no need to remove PHPCR as tests are green again. Maybe we can continue discussing the release of v2.0?

[alexislefebvre]

I think that we'll publish a beta once we'll have found a workaround for #423.

I don't see anything right now that block a beta and a stable release.

[alexislefebvre]

I would to fix these issues before releasing a final beta version:

• Fails to connect into mysql database when database not created Fails to connect into mysql database when database not created #470
• Backup is wrong Backup is wrong #415

Bonus:

• Conflict with dama/doctrine-test-bundle Conflict with dama/doctrine-test-bundle #423

[alexislefebvre]

Can someone please review #476?

[alexislefebvre]

Thanks everybody for your help.

I'm closing this in favor of #496