Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfl: disable building protobuf library #104

Closed
wants to merge 3 commits into from

Conversation

ligurio
Copy link
Owner

@ligurio ligurio commented Aug 20, 2024

The patch disables building protobuf library, this will speed up overall build time significantly.

@ligurio ligurio force-pushed the ligurio/cfl-disable-protobuf-building branch from e859c7f to e83fc77 Compare August 20, 2024 13:12
@ligurio ligurio marked this pull request as draft September 5, 2024 16:00
@ligurio ligurio closed this Oct 10, 2024
The patch disables building protobuf library, this will speed up
overall build time significantly.
@ligurio ligurio reopened this Dec 11, 2024
@ligurio ligurio force-pushed the ligurio/cfl-disable-protobuf-building branch from e83fc77 to 9396030 Compare December 11, 2024 08:01
@ligurio
Copy link
Owner Author

ligurio commented Dec 11, 2024

/src/lua-c-api-tests/build/tests/capi/external.protobuf_mutator/src/external.protobuf_mutator/src/mutator.cc:90:41: error: no member named 'has_presence' in 'google::protobuf::FieldDescriptor'
   90 |   return !field.is_repeated() && !field.has_presence();
      |                                   ~~~~~ ^
/src/lua-c-api-tests/build/tests/capi/external.protobuf_mutator/src/external.protobuf_mutator/src/mutator.cc:383:15: error: call to non-static member function without an object argument
  383 |   return Any::GetDescriptor() == message->GetDescriptor()
      |          ~~~~~^~~~~~~~~~~~~
/src/lua-c-api-tests/build/tests/capi/external.protobuf_mutator/src/external.protobuf_mutator/src/mutator.cc:389:15: error: call to non-static member function without an object argument
  389 |   return Any::GetDescriptor() == message->GetDescriptor()
      |          ~~~~~^~~~~~~~~~~~~
3 errors generated.

@ligurio
Copy link
Owner Author

ligurio commented Dec 11, 2024

/src/lua-c-api-tests/build/tests/capi/external.protobuf_mutator/src/external.protobuf_mutator/src/text_format.cc:31:10: error: no member named 'SetRecursionLimit' in 'google::protobuf::TextFormat::Parser'
   31 |   parser.SetRecursionLimit(100);
      |   ~~~~~~ ^
/src/lua-c-api-tests/build/tests/capi/external.protobuf_mutator/src/external.protobuf_mutator/src/text_format.cc:33:10: error: no member named 'AllowUnknownField' in 'google::protobuf::TextFormat::Parser'
   33 |   parser.AllowUnknownField(true);
      |   ~~~~~~ ^
2 errors generated.

@ligurio
Copy link
Owner Author

ligurio commented Dec 16, 2024

Seems LPM requires newer Protobuf version than packaged on Ubuntu.

@ligurio ligurio closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant