Skip to content

chainrpc: return Unavailable while notifier starts #10352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

chainrpc: return Unavailable while notifier starts #10352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9520a39
chainrpc: return Unavailable while notifier starts
starius Nov 6, 2025
e4313eb
docs: add release notes entry
starius Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/release-notes/release-notes-0.20.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@
- [Fixed a bug](https://github.com/lightningnetwork/lnd/pull/10330) to ensure that goroutine resources are properly freed in the case
of a disconnection or other failure event.

- Chain notifier RPCs now [return the gRPC `Unavailable`
status](https://github.com/lightningnetwork/lnd/pull/10352) while the
sub-server is still starting. This allows clients to reliably detect the
transient condition and retry without brittle string matching.

# New Features

* Use persisted [nodeannouncement](https://github.com/lightningnetwork/lnd/pull/8825)
Expand Down Expand Up @@ -283,7 +288,7 @@ reader of a payment request.
* [Require invoices to include a payment address or blinded paths](https://github.com/lightningnetwork/lnd/pull/9752)
to comply with updated BOLT 11 specifications before sending payments.

* [LND can now recgonize DNS address type in node
* [LND can now recognize DNS address type in node
announcement msg](https://github.com/lightningnetwork/lnd/pull/9455). This
allows users to forward node announcement with valid DNS address types. The
validity aligns with Bolt 07 DNS constraints.
Expand Down
6 changes: 4 additions & 2 deletions lnrpc/chainrpc/chain_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import (
"github.com/lightningnetwork/lnd/lnrpc"
"github.com/lightningnetwork/lnd/macaroons"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
"gopkg.in/macaroon-bakery.v2/bakery"
)

Expand Down Expand Up @@ -84,8 +86,8 @@ var (

// ErrChainNotifierServerNotActive indicates that the chain notifier hasn't
// finished the startup process.
ErrChainNotifierServerNotActive = errors.New("chain notifier RPC is " +
"still in the process of starting")
ErrChainNotifierServerNotActive = status.Error(codes.Unavailable,
"chain notifier RPC is still in the process of starting")
)

// ServerShell is a shell struct holding a reference to the actual sub-server.
Expand Down