Skip to content

Commit e87609b

Browse files
committed
perms: move perms.go into taprpc
The Lightning Node Connect WASM client requires access to `perms.go` for RPC endpoint-related permissions. We move it into taprpc so that the WASM build only needs to depend on the taprpc module, without importing the entire taproot-assets module.
1 parent 0d77fc9 commit e87609b

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

server.go

+3-4
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import (
1717
"github.com/lightninglabs/taproot-assets/address"
1818
"github.com/lightninglabs/taproot-assets/fn"
1919
"github.com/lightninglabs/taproot-assets/monitoring"
20-
"github.com/lightninglabs/taproot-assets/perms"
2120
"github.com/lightninglabs/taproot-assets/rfqmsg"
2221
"github.com/lightninglabs/taproot-assets/rpcperms"
2322
"github.com/lightninglabs/taproot-assets/tapchannel"
@@ -133,7 +132,7 @@ func (s *Server) initialize(interceptorChain *rpcperms.InterceptorChain) error {
133132
Checkers: []macaroons.Checker{
134133
macaroons.IPLockChecker,
135134
},
136-
RequiredPerms: perms.RequiredPermissions,
135+
RequiredPerms: taprpc.RequiredPermissions,
137136
},
138137
)
139138
if err != nil {
@@ -158,7 +157,7 @@ func (s *Server) initialize(interceptorChain *rpcperms.InterceptorChain) error {
158157

159158
// Register all our known permission with the macaroon
160159
// service.
161-
for method, ops := range perms.RequiredPermissions {
160+
for method, ops := range taprpc.RequiredPermissions {
162161
err := interceptorChain.AddPermission(
163162
method, ops,
164163
)
@@ -311,7 +310,7 @@ func (s *Server) RunUntilShutdown(mainErrChan <-chan error) error {
311310
serverOpts := s.cfg.GrpcServerOpts
312311

313312
// Get RPC endpoints which don't require macaroons.
314-
macaroonWhitelist := perms.MacaroonWhitelist(
313+
macaroonWhitelist := taprpc.MacaroonWhitelist(
315314
s.cfg.UniversePublicAccess.IsReadAccessGranted(),
316315
s.cfg.UniversePublicAccess.IsWriteAccessGranted(),
317316
s.cfg.RPCConfig.AllowPublicUniProofCourier,

taprpc/go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ require (
99
github.com/lightningnetwork/lnd v0.18.0-beta.rc4.0.20240723043204-f09d4042aee4
1010
google.golang.org/grpc v1.59.0
1111
google.golang.org/protobuf v1.33.0
12+
gopkg.in/macaroon-bakery.v2 v2.0.1
1213
)
1314

1415
require (
@@ -162,7 +163,6 @@ require (
162163
google.golang.org/genproto/googleapis/api v0.0.0-20231016165738-49dd2c1f3d0b // indirect
163164
google.golang.org/genproto/googleapis/rpc v0.0.0-20231030173426-d783a09b4405 // indirect
164165
gopkg.in/errgo.v1 v1.0.1 // indirect
165-
gopkg.in/macaroon-bakery.v2 v2.0.1 // indirect
166166
gopkg.in/macaroon.v2 v2.0.0 // indirect
167167
gopkg.in/natefinch/lumberjack.v2 v2.0.0 // indirect
168168
gopkg.in/yaml.v2 v2.4.0 // indirect

perms/perms.go renamed to taprpc/perms.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package perms
1+
package taprpc
22

33
import "gopkg.in/macaroon-bakery.v2/bakery"
44

0 commit comments

Comments
 (0)