Skip to content

Include non-permanently connected peers in list_peers #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tnull opened this issue Apr 7, 2023 · 1 comment · Fixed by #95
Closed

Include non-permanently connected peers in list_peers #62

tnull opened this issue Apr 7, 2023 · 1 comment · Fixed by #95

Comments

@tnull
Copy link
Collaborator

tnull commented Apr 7, 2023

As of #56, we allow to retrieve all permanently stored peers and add a is_connected: bool field based on their connection status.

It would however be nice to eventually return the superset of stored and connected (i.e., also peer not marked as permanently) peers.

This is much easier after lightningdevkit/rust-lightning#2056, which is why we postpone until then.
@tnull tnull mentioned this issue Apr 7, 2023
Merged
@tnull
Copy link
Collaborator Author

tnull commented May 3, 2023

Blocked on #85 now.

@tnull tnull mentioned this issue May 12, 2023
Merged
@tnull tnull closed this as completed in #95 Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include non-permanently connected peers in list_peers() tnull/ldk-node
1 participant
@tnull