[WIP] Text engine Refactor #585
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets resolve fonts a little quicker. Going to a distributed font handler instead of a central one that did both Pureify the old TrFontManager that had a bunch of unused complicated code for weighting.
…ode and related components
…Face, and updating FontFamilyMap to use FontFace directly
- Added `calculateRenderInfo.ts` for calculating text rendering metrics and layout. - Implemented `draw.ts` for rendering text onto canvas with support for highlights and shadows. - Removed the deprecated `LightningTextTextureRenderer.ts` to streamline text rendering.
…n for Canvas and SDF
6x slowdown:
with this PR: create: 268.96ms ±18.12
without: create: 743.60ms ±38.26
for reference:
beta 9: create: 426.59ms ±40.61
This does include `{ willReadFrequently: true }` as it did have a
serious impact on perf in Chrome - we will need to test on a WPE device
to get the impact on a real device. I'd imagine GPU vs CPU rendering to
be of a bigger impact there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #483
Work in progress: