Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogRedacting panics on nil value logging #427

Closed
aloknnikhil opened this issue Apr 16, 2020 · 1 comment · Fixed by #428
Closed

LogRedacting panics on nil value logging #427

aloknnikhil opened this issue Apr 16, 2020 · 1 comment · Fixed by #428
Labels

Comments

@aloknnikhil
Copy link

With the new log redaction feature, we are seeing crashes in the logger when one of the values to be logged is nil

Example:

log.Debugf("RetrieveInterfaceStatusFromRamCache: %+v", ifStatus)

This panics if ifStatus is a pointer and is nil. It's completely valid in some cases to have a "nil" printed to the log.

@ondrej-fabry
Copy link
Member

Please post the panic output with stack trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants