Skip to content

Commit 17e677f

Browse files
committed
Perl Tidy!!!
The mixture of indention practices throughout made it hard to read through certain bits of the code. In an effort to make it easier to see upcoming code changes more clearly, a few things have been done: * Stole the `.perltidyrc` from the libwww-perl distribution * Ran tidy on all tests in the test suite * Removed all obvious indirect object syntax in the test suite i.e. $x = new X; to $x = X->new; * Ran tidy on Daemon.pm * turned on Test::EOL in the dist.ini * turned on Test::NoTabs in the dist.ini * Fix the .perltidyrc per suggestions from @karenetheridge
1 parent 0031cfc commit 17e677f

File tree

10 files changed

+735
-726
lines changed

10 files changed

+735
-726
lines changed

.perltidyrc

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
-pbp # Start with Perl Best Practices
2+
-nst # undo -st from -pbp, to allow for command line use
3+
-w # Show all warnings
4+
-iob # Ignore old breakpoints
5+
-l=80 # 80 characters per line
6+
-mbl=2 # No more than 2 blank lines
7+
-i=4 # Indentation is 4 columns
8+
-ci=4 # Continuation indentation is 4 columns
9+
-vt=0 # Less vertical tightness
10+
-pt=2 # High parenthesis tightness
11+
-bt=2 # High brace tightness
12+
-sbt=2 # High square bracket tightness
13+
-isbc # Don't indent comments without leading space

Changes

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
Revision history for HTTP-Daemon
22

33
{{$NEXT}}
4+
- Added the .perltidyrc from the libwww-perl distribution
5+
- Tidied the test suite with perltidy
6+
- Tidied Daemon.pm
7+
- Turned on EOL and tab tests
8+
- Removed obvious indirect object syntax in test suite
49

510
6.04 2019-04-02 13:09:45Z
611
- Remove circular dependency on LWP::RobotUA introduced in 6.02 (GH#29)

dist.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ copyright_year = 1995
88
:version = 0.097
99
Authority.authority = cpan:GAAS
1010
Test::MinimumVersion.max_target_perl = 5.008001
11-
-remove = Test::EOL ; TODO
12-
-remove = Test::NoTabs ; TODO
11+
; -remove = Test::EOL ; TODO
12+
; -remove = Test::NoTabs ; TODO
1313
-remove = Test::CleanNamespaces ; TODO
1414
-remove = Test::PodSpelling ; TODO
1515
-remove = AutoMetaResources ; override default of using RT for bug tracking

0 commit comments

Comments
 (0)