fix _xml_escape method name so sub-classes still work as expected

fix comment fooling Module::ExtractUse

Author: Jeff Fearn

lib/HTML/Element.pm

@@ -1263,7 +1263,8 @@ sub delete_content {
                 #  will keep calls to detach() from trying to uselessly filter
                 #  the list (as they won't be able to see it once it's been
                 #  deleted)
-                || return ( $_[0] )    # in case of no content
+                || return ( $_[0] )
+                    # in case of no content
         },
         0
 
@@ -2095,7 +2096,7 @@ sub _xml_escape_text {
     return;
 }
 
-sub _xml_escape_attr {
+sub _xml_escape {
 
 # DESTRUCTIVE (a.k.a. "in-place")
 # In addition to other escapes, also escape apostrophe and double-quote
@@ -2350,7 +2351,7 @@ sub starttag_XML {
         # Hm -- what to do if val is undef?
         # I suppose that shouldn't ever happen.
         next if !defined( $val = $self->{$_} );    # or ref $val;
-        _xml_escape_attr($val);
+        _xml_escape($val);
         $tag .= qq{ $_="$val"};
     }
     @_ == 3 ? "$tag />" : "$tag>";

t/escape.t

@@ -61,24 +61,24 @@ $HTML::Element::encoded_content = 1;
 
 foreach my $orig ( keys %translations ) {
     my $new = $orig;
-    HTML::Element::_xml_escape_attr($new);
+    HTML::Element::_xml_escape($new);
     is( $new, $translations{$orig}, "Properly escaped: $orig" );
 }
 
 # test that multiple runs don't change the value
 my $test_orig = '&foo; &bar;';
 my $test_str  = $test_orig;
-HTML::Element::_xml_escape_attr($test_str);
+HTML::Element::_xml_escape($test_str);
 is( $test_str, $test_orig, "Multiple runs 1" );
-HTML::Element::_xml_escape_attr($test_str);
+HTML::Element::_xml_escape($test_str);
 is( $test_str, $test_orig, "Multiple runs 2" );
-HTML::Element::_xml_escape_attr($test_str);
+HTML::Element::_xml_escape($test_str);
 is( $test_str, $test_orig, "Multiple runs 3" );
 
 # test default path, always encode '&'
 $HTML::Element::encoded_content = 0;
 $test_str  = $test_orig;
 my $test_expected = '&foo; &bar;';
-HTML::Element::_xml_escape_attr($test_str);
+HTML::Element::_xml_escape($test_str);
 is( $test_str, $test_expected, "Default encode" );