GCC 4.8 -Wmaybe-uninitialized is *really* dumb

rmw42 · rmw42 · commit 4ee5bfc01343 · 2018-10-12T10:22:10.000+01:00
diff --git a/src/misc/ssh/ssh_decode_sequence_multi.c b/src/misc/ssh/ssh_decode_sequence_multi.c
@@ -53,6 +53,7 @@ int ssh_decode_sequence_multi(const unsigned char *in, unsigned long inlen, ...)
       }
 
       /* Calculate (or read) length of data */
+      size = (unsigned long)-1;
       switch (type) {
          case LTC_SSHDATA_BYTE:
          case LTC_SSHDATA_BOOLEAN:
@@ -74,7 +75,6 @@ int ssh_decode_sequence_multi(const unsigned char *in, unsigned long inlen, ...)
 
          case LTC_SSHDATA_EOL:
             /* Should never get here */
-            size = (unsigned long)-1;
             err = CRYPT_INVALID_ARG;
             goto error;
       }

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ int ssh_decode_sequence_multi(const unsigned char *in, unsigned long inlen, ...)`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`/* Calculate (or read) length of data */`
	`56`	`+ size = (unsigned long)-1;`
`56`	`57`	`switch (type) {`
`57`	`58`	`case LTC_SSHDATA_BYTE:`
`58`	`59`	`case LTC_SSHDATA_BOOLEAN:`
`@@ -74,7 +75,6 @@ int ssh_decode_sequence_multi(const unsigned char *in, unsigned long inlen, ...)`
`74`	`75`
`75`	`76`	`case LTC_SSHDATA_EOL:`
`76`	`77`	`/* Should never get here */`
`77`		`- size = (unsigned long)-1;`
`78`	`78`	`err = CRYPT_INVALID_ARG;`
`79`	`79`	`goto error;`
`80`	`80`	`}`