Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to draw circles #1419

Open
SDLBugzilla opened this issue Feb 10, 2021 · 4 comments
Open

Add a function to draw circles #1419

SDLBugzilla opened this issue Feb 10, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

Reported in version: HG 2.1
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2014-03-29 02:02:21 +0000, Matheus Valadares wrote:

It seems that the 2D rendering subsystem doesn't have any functions to draw circles, is that an overlook or something that isn't intended to be implemented?

On 2016-07-30 18:40:53 +0000, Luxon Jean-Pierre wrote:

I recently implemented two functions that draw a circle on a renderer:

  • SDL_RenderDrawCircle
  • SDL_RenderFillCircle

You can find the implementation here :
https://gist.github.com/Gumichan01/332c26f6197a432db91cc4327fcabb1c

I cannot submit this on the repository because I do not have the write :-/

On 2016-08-01 20:34:41 +0000, Philipp Wiesemann wrote:

The loop condition in the linked implementation seems wrong. It should be "offsety >= offsetx" instead of "y >= x".

On 2016-08-02 10:15:05 +0000, Luxon Jean-Pierre wrote:

Yes, I fixed that.

On 2018-08-06 21:20:19 +0000, Ryan C. Gordon wrote:

Hello, and sorry if you're getting dozens of copies of this message by email.

We are closing out bugs that appear to be abandoned in some form. This can happen for lots of reasons: we couldn't reproduce it, conversation faded out, the bug was noted as fixed in a comment but we forgot to mark it resolved, the report is good but the fix is impractical, we fixed it a long time ago without realizing there was an associated report, etc.

Individually, any of these bugs might have a better resolution (such as WONTFIX or WORKSFORME or INVALID) but we've added a new resolution of ABANDONED to make this easily searchable and make it clear that it's not necessarily unreasonable to revive a given bug report.

So if this bug is still a going concern and you feel it should still be open: please feel free to reopen it! But unless you respond, we'd like to consider these bugs closed, as many of them are several years old and overwhelming our ability to prioritize recent issues.

(please note that hundred of bug reports were sorted through here, so we apologize for any human error. Just reopen the bug in that case!)

Thanks,
--ryan.

@SDLBugzilla SDLBugzilla added abandoned Bug has been abandoned for various reasons enhancement New feature or request labels Feb 10, 2021
@stianhoiland
Copy link

Why is this abandoned?

@slouken
Copy link
Collaborator

slouken commented Feb 22, 2023

I don’t know, this seems useful to me. I’ll reopen it for SDL 3.0, thanks!

@slouken slouken reopened this Feb 22, 2023
@slouken slouken added this to the 3.2.0 milestone Feb 22, 2023
@slouken slouken self-assigned this Feb 22, 2023
@icculus
Copy link
Collaborator

icculus commented Feb 22, 2023

If we were to add this--and I'm not sure we should--we'd want to probably have most of the backends render a single rectangle and use a pixel shader to carve it down to a circle. But I haven't thought it through.

The code in that gist could just be copied into an app without any changes to SDL though, since it just renders with points and lines.

@slouken slouken removed the abandoned Bug has been abandoned for various reasons label Nov 4, 2023
@slouken slouken modified the milestones: 3.2.0, 3.x May 20, 2024
@stianhoiland
Copy link

Is it bad manners to /bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants