Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPS Soft Patching Support? #244

Open
erfanCA01 opened this issue Feb 10, 2024 · 4 comments
Open

IPS Soft Patching Support? #244

erfanCA01 opened this issue Feb 10, 2024 · 4 comments

Comments

@erfanCA01
Copy link

erfanCA01 commented Feb 10, 2024

love the gpsp core for its speed on handhelds, any plans to bring softpatching support for rom hacks and fixes? thank you, mgba core already supports it but gpsp has far better fast forward speed

@hizzlekizzle
Copy link

Hmm, it looks like it "needs_fullpath", which is what controls whether softpatching works or not. This means the core needs direct access to the file rather than accessing it from memory. I'm surprised this is the case, though.

@SuperrSonic
Copy link

SuperrSonic@e90e8b8
SuperrSonic@8c2d8b9

I wanted this option since extracting a 16 MB game to a cheap sd card can be painfully slow on Wii.
I don't really understand why it relies on keeping access to the file so I didn't feel confident submitting a pull request.
These changes weren't hard to do, I was surprised I got it working on the first try, but maybe it can be of help to someone.

@jindaxia
Copy link

jindaxia commented Dec 30, 2024

SuperrSonic@e90e8b8 SuperrSonic@8c2d8b9

I wanted this option since extracting a 16 MB game to a cheap sd card can be painfully slow on Wii. I don't really understand why it relies on keeping access to the file so I didn't feel confident submitting a pull request. These changes weren't hard to do, I was surprised I got it working on the first try, but maybe it can be of help to someone.

Thanks a lot, I also need this feature, but I canot code c

And why not make a PR,

@SuperrSonic
Copy link

On GameCube this change prevents ROMs bigger than 4MB from loading, that's a bit excessive. Without my changes one is able to load even 32MB games just fine.

Maybe if a compiler flag gets added, it would be more acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants