Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js-libp2p-gossipsub dedups messages with same content #29

Closed
p-shahi opened this issue Apr 10, 2023 · 0 comments · Fixed by #31
Closed

js-libp2p-gossipsub dedups messages with same content #29

p-shahi opened this issue Apr 10, 2023 · 0 comments · Fixed by #31

Comments

@p-shahi
Copy link
Member

p-shahi commented Apr 10, 2023

Connect two browser nodes via relay node using the websocket transport
browser 1 posts "hello", received by browser2
post hello again, no message received on the relay node or on browser 2
@p-shahi p-shahi mentioned this issue Apr 11, 2023
Merged
maschad added a commit that referenced this issue Apr 11, 2023
@maschad
fix: cast all messages as signed for deduping (#29)

Verified

This commit was signed with the committer’s verified signature.
maschad Chad Nehemiah
GPG key ID: 598DA8C1F9A33FD1
Verified
Learn about vigilant mode
c742457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use sequence number in msgIdFn to dedup msgs libp2p/universal-connectivity
1 participant
@p-shahi