Ds 5114 update the aws secrets provider to aws sdk v2 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityadani
reviewed
Jul 6, 2023
adityadani
reviewed
Jul 6, 2023
adityadani
approved these changes
Sep 15, 2023
Collaborator
adityadani
left a comment
adityadani
left a comment
There was a problem hiding this comment.
looks good once the integration tests are fixed.
| } | ||
| providers = append(providers, ec2RoleProvider) | ||
|
|
||
| } else if runningOnEc2 { |
Collaborator
There was a problem hiding this comment.
Curious, does AWS not allow chaining of providers anymore? Previously we were able to add EnvProvider and RoleProvider together. With this change we won't since each provider is in its own if condition.
| // Delete of a key that exists should succeed | ||
| err := a.s.DeleteSecret(a.secretIdWithData, nil) | ||
| keyContext := make(map[string]string) | ||
| keyContext[SecretRetentionPeriodInDaysKey] = "7" |
Collaborator
There was a problem hiding this comment.
If you ad a retention period then the subsequent GetSecret check is going to fail ? The integration tests are failing for SecretsManager. Can you check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In this PR we have updated the packages used from aws sdk version 1 to aws sdk version 2. This has been made to maintain consistency in using the same aws sdk version across libopenstorage/secrets and portworx/pds-api repositories.
Which issue(s) this PR fixes (optional)
Closes #DS-5114
Special notes for your reviewer: