Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ for Windows: Build error on windows #90

Open
kinnefix opened this issue Feb 7, 2019 · 3 comments
Open

FAQ for Windows: Build error on windows #90

kinnefix opened this issue Feb 7, 2019 · 3 comments
Assignees
Labels

Comments

@kinnefix
Copy link

kinnefix commented Feb 7, 2019

I'm not really sure how I can contribute to the source code, so I'm posting it here.
I was trying to build glui using msbuild CLI.
I first generated glui.sln using cmake command.
I then issued msbuild glui.sln, but got the error complaining about errors in gl.h from windows sdk.
As a solution, I added #include <windows.h> right before inclusion of GL/gl.h, but I got another error indicating that I needed to define NOMINMAX for some reason. Setting such macro seemed to have solved the problem, and I successfully got resulting library.
Should I make a diff file so that someone with the right access to this repository can apply it?

@nigels-com nigels-com added the bug label Mar 14, 2019
@nigels-com
Copy link
Collaborator

I'd be happy to consider a pull request for better supporting the Windows build.

I could perhaps contribute by providing an AppVeyor build, but I don't tend to do much Windows development nowadays, generally.

@nigels-com
Copy link
Collaborator

I came across the same issue myself, visiting Windows recently.

I'll add some per-platform notes to include the advice about windows.h and NOMINMAX.

@nigels-com nigels-com changed the title Build error on windows FAQ for Windows: Build error on windows Jun 10, 2019
@nigels-com nigels-com self-assigned this Jun 10, 2019
@nigels-com
Copy link
Collaborator

cmake-gui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants