Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using parking lot behaviour not all vehicles are detected with "2D Ground Truth Sensor" in version 3.2021 #1852

Open
zvika-waissbaum opened this issue Nov 3, 2021 · 12 comments
Labels
question Further information is requested

Comments

@zvika-waissbaum
Copy link

zvika-waissbaum commented Nov 3, 2021

When using parking lot behaviour not all vehicles are detected with "2D Ground Truth Sensor".
Configuration:
Ubuntu 20.04
CPU: Intel i7
GPU: RTX2070
Simulator version 2021.3

@EricBoiseLGSVL
Copy link
Contributor

Are you using API vehicles? Please let us know more details to understand what the issue could be. We have a bug with api pedestrians and npcs might have this issue as well.

@EricBoiseLGSVL EricBoiseLGSVL added the question Further information is requested label Nov 3, 2021
@zvika-waissbaum
Copy link
Author

zvika-waissbaum commented Nov 4, 2021

Please explain what are API vehicles. I'm using the default NPCs, 2 private NPCs that I created (but doesn't influence the outcome) and Behaviour NPC (Drunk driver and parking lot). When adding the parking lot asset-bundle (I see now that it also influence the outcome), some vehicles are not detected in the "2D Ground Truth Sensor". The upper picture is with behaviour and the lower is without.
With_behavior

Without_behavior
.

@EricBoiseLGSVL
Copy link
Contributor

I feel you are seeing a bug we have with GT2D. We are looking into it now. I'll post the fix here so you can test if it helps when we have it done. Thanks for posting.

@EricBoiseLGSVL EricBoiseLGSVL added bug Something isn't working and removed question Further information is requested labels Nov 4, 2021
@EricBoiseLGSVL
Copy link
Contributor

We have tested internally and groundtruth 2d is working with npc vehicles. Do you have the ground truth sensor at the base link? Where is it located on the vehicle?

@EricBoiseLGSVL EricBoiseLGSVL added question Further information is requested and removed bug Something isn't working labels Nov 5, 2021
@zvika-waissbaum
Copy link
Author

Yes, The "2D ground truth" sensor is located at the base link.
Please test it with a lot of vehicles.
Use the parking lot behaviour, it can help.

Screenshot from 2021-11-07 09-39-54
Screenshot from 2021-11-07 09-40-54

@EricBoiseLGSVL
Copy link
Contributor

I see that you have the GT2d sensor rotated. This might be causing an issue. Please try to move it here and see if it has the same issue:
image

@heeen
Copy link
Contributor

heeen commented Nov 10, 2021

Can you clarify which NPCs are detected and which are not? Is it always the same NPCs or are all vehicles sometimes detected?
Is it the drunkdriver and parking lot vehicles that are consistently not detected or the regular NPCs?

@heeen
Copy link
Contributor

heeen commented Nov 10, 2021

here it was discovered that python created pedestrians are not detected: #1797 (comment) I believe this is the same cause for NPCs not being detected. Since GT sensor relies on the right layer mask being set on entities I suspect that API created pedestrians and NPCs are not placed in the right layer and thus invisible to the sensor

@zvika-waissbaum
Copy link
Author

Can you clarify which NPCs are detected and which are not? Is it always the same NPCs or are all vehicles sometimes detected? Is it the drunkdriver and parking lot vehicles that are consistently not detected or the regular NPCs?

It happens randomly. It is influenced by the parking lot behaviour not the drunk driver, probably because there are a lot of vehicles. I know for sure that the regular NPC are sometimes not detected, probably the parking ones also. I'll check.
I'll also try to move the camera.

@zvika-waissbaum zvika-waissbaum changed the title When using drunk driver behaviour not all vehicles are detected with "2D Ground Truth Sensor" When using parking lot behaviour not all vehicles are detected with "2D Ground Truth Sensor" in version 3.2021 Nov 10, 2021
@heeen
Copy link
Contributor

heeen commented Nov 10, 2021

are you seeing the error about too many vehicles being detected?

@kamkolak-lge
Copy link
Contributor

kamkolak-lge commented Nov 10, 2021

@zvika-waissbaum
Thank you for reporting the issue. We have identified it as a problem with BehavioursNPC plugin and we're working on the fix.

In the meantime, if you still want to use this behaviour, you can remove line 43 (overriding NPCPoolSize value) in ParkingNPCManager.cs and rebuild the NPCParkingBehaviour plugin. NPC pool size should be then reduced to manageable amount and the sensor will detect all vehicles.

@zvika-waissbaum
Copy link
Author

zvika-waissbaum commented Nov 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants