Skip to content

Commit 94dfc89

Browse files
committed
update CI config
1 parent 47ed070 commit 94dfc89

File tree

4 files changed

+26
-15
lines changed

4 files changed

+26
-15
lines changed

.github/workflows/clang-format.yml

+3-7
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
1-
name: clang-format-review
1+
name: check clang-format
22

33
# You can be more specific, but it currently only works on pull requests
44
on: [pull_request]
55

66
jobs:
77
clang-format:
8-
runs-on: ubuntu-20.04
8+
runs-on: ubuntu-24.04
99
steps:
10-
- uses: actions/checkout@v2
11-
- name: Install clang-tidy
12-
run: |
13-
sudo apt-get update
14-
sudo apt-get install -y clang-tidy
10+
- uses: actions/checkout@v4
1511
- name: Analyze
1612
run: |
1713
clang-format --dry-run --Werror -style=file $(find ./ -name '*.cc' -print)

.github/workflows/clang-tidy.yml

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
name: check clang-tidy
2+
3+
# You can be more specific, but it currently only works on pull requests
4+
on: [pull_request]
5+
6+
jobs:
7+
clang-tidy:
8+
runs-on: ubuntu-24.04
9+
steps:
10+
- uses: actions/checkout@v4
11+
- name: configure
12+
run: |
13+
mkdir build
14+
cd build
15+
cmake ..
16+
- name: build the library
17+
run: cmake --build build
18+
- name: build examples
19+
run:
20+
cmake --build build --target examples

.github/workflows/main.yaml

+2-7
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,12 @@ jobs:
1717
os: [ubuntu-latest, windows-latest, macos-latest]
1818

1919
steps:
20-
- uses: actions/checkout@v1
21-
- name: Install clang-tidy
22-
run: |
23-
sudo apt-get update
24-
sudo apt-get install -y clang-tidy
25-
if: matrix.os == 'ubuntu-latest'
20+
- uses: actions/checkout@v4
2621
- name: configure
2722
run: |
2823
mkdir build
2924
cd build
30-
cmake ..
25+
cmake .. -DREACTOR_CPP_CLANG_TIDY=Off
3126
- name: build the library
3227
run: cmake --build build
3328
- name: build examples

include/reactor-cpp/value_ptr.hh

+1-1
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ public:
355355
* class:`ImmutableValuePtr`, the value is deleted.
356356
* @endrst
357357
*/
358-
auto operator=(ImmutableValuePtr&& ptr) -> ImmutableValuePtr& = default;
358+
auto operator=(ImmutableValuePtr&& ptr) noexcept -> ImmutableValuePtr& = default;
359359

360360
/**
361361
* Retrieve a raw pointer to the managed value.

0 commit comments

Comments
 (0)