If we enjoy the github setting which blocks pull request merges until all review conversations have been resolved, then we should consider revising our workflows to submit review comments instead of issue comments.
https://github.com/letsencrypt/boulder/blob/main/.github/workflows/cps-review.yml, and https://github.com/letsencrypt/boulder/blob/main/.github/workflows/issue-for-sre-handoff.yml both use github-script, which provides an octokit client, which supports creating review comments.
It also supports subject_type:file, so the review comment is not placed on a specific line of code, but can be tied to, for example features.go when a feature flag is introduced.
If we enjoy the github setting which blocks pull request merges until all review conversations have been resolved, then we should consider revising our workflows to submit review comments instead of issue comments.
https://github.com/letsencrypt/boulder/blob/main/.github/workflows/cps-review.yml, and https://github.com/letsencrypt/boulder/blob/main/.github/workflows/issue-for-sre-handoff.yml both use
github-script, which provides anoctokitclient, which supports creating review comments.It also supports
subject_type:file, so the review comment is not placed on a specific line of code, but can be tied to, for examplefeatures.gowhen a feature flag is introduced.