This repository was archived by the owner on Jan 26, 2023. It is now read-only.
example hcl minor cleanup #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s port, nor does it need to use a tcp liveness check on the redis-server. That's the redis-server's task's job.
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage ? 35.05%
=======================================
Files ? 2
Lines ? 194
Branches ? 0
=======================================
Hits ? 68
Misses ? 119
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
pgporada
approved these changes
Jul 29, 2022
jcjones
commented
Aug 10, 2022
Author
|
@pgporada fixed it, it now should be merged! |
pgporada
approved these changes
Jan 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attache-control task does not need to advertise the redis-server's port, nor does it need to use a tcp liveness check on the redis-server. That's the redis-server's task's job.