fix: #1341

Use more efficient `{TemplateBinding}` for `MenuItem` templates, which also fixes the incorrect `{Binding Path}` syntax for attached properties.

Author: JohnTasler

src/Wpf.Ui/Controls/Menu/MenuItem.xaml

@@ -77,12 +77,12 @@
                     <!-- TextBlock added so that screen readers don't try to read Icon -->
                     <TextBlock Grid.Column="0"
                         Grid.ColumnSpan="3"
-                        Width="{Binding Width, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
-                        Height="{Binding Height, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
+                        Width="{TemplateBinding Width}"
+                        Height="{TemplateBinding Height}"
                         Margin="-10"
                         FontSize="1"
                         Opacity="0"
-                        Text="{Binding AutomationProperties.Name, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
+                        Text="{TemplateBinding AutomationProperties.Name}"
                         Background="Black"/>
                 </Grid>
 
@@ -194,12 +194,12 @@
                 <!-- TextBlock added so that screen readers don't try to read Icon -->
                 <TextBlock Grid.Column="0"
                    Grid.ColumnSpan="3"
-                   Width="{Binding Width, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
-                   Height="{Binding Height, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
+                   Width="{TemplateBinding Width}"
+                   Height="{TemplateBinding Height}"
                    Margin="-10"
                    FontSize="1"
                    Opacity="0"
-                   Text="{Binding AutomationProperties.Name, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
+                   Text="{TemplateBinding AutomationProperties.Name}"
                    Background="Black"/>
             </Grid>
         </Border>
@@ -288,12 +288,12 @@
                 <!-- TextBlock added so that screen readers don't try to read Icon -->
                 <TextBlock Grid.Column="0"
                    Grid.ColumnSpan="5"
-                   Width="{Binding Width, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
-                   Height="{Binding Height, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
+                   Width="{TemplateBinding Width}"
+                   Height="{TemplateBinding Height}"
                    Margin="-10"
                    FontSize="1"
                    Opacity="0"
-                   Text="{Binding AutomationProperties.Name, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
+                   Text="{TemplateBinding AutomationProperties.Name}"
                    Background="Black"/>
             </Grid>
         </Border>
@@ -369,12 +369,12 @@
                     <!-- Fix double narration from mousing over the button and then the associated text -->
                     <TextBlock Grid.Column="0"
                         Grid.ColumnSpan="3"
-                        Width="{Binding Width, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
-                        Height="{Binding Height, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
+                        Width="{TemplateBinding Width}"
+                        Height="{TemplateBinding Height}"
                         Margin="-10"
                         FontSize="1"
                         Opacity="0"
-                        Text="{Binding AutomationProperties.Name, RelativeSource={RelativeSource AncestorType={x:Type MenuItem}}}"
+                        Text="{TemplateBinding AutomationProperties.Name}"
                         Background="Black"/>
                 </Grid>
             </Border>