Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fieldname in report returned by fit_sipm_wl? #129

Open
fhagemann opened this issue Mar 5, 2025 · 1 comment
Open

Rename fieldname in report returned by fit_sipm_wl? #129

fhagemann opened this issue Mar 5, 2025 · 1 comment
Assignees
@theHenks
Labels
bug Something isn't working

Comments

@fhagemann
Copy link
Contributor

fhagemann commented Mar 5, 2025 •
edited
Loading

In the SiPM optimization fit routine, one field in the report is called a_grid_wl_sg which looks like a left-over from the aoe_optimization. Should this be renamed or will we keep it like this?

LegendSpecFits.jl/src/sipm_filter_optimization.jl

Line 84 in 391ed7e

a_grid_wl_sg = wls,

@theHenks
Copy link
Collaborator

theHenks commented Mar 5, 2025

Yes, that is a copy and paste error

@theHenks theHenks self-assigned this Mar 9, 2025
@theHenks theHenks added the bug Something isn't working label Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theHenks theHenks

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fhagemann @theHenks