Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js Sentry source maps #163

Closed
Vadorequest opened this issue Apr 3, 2020 · 5 comments
Closed

Next.js Sentry source maps #163

Vadorequest opened this issue Apr 3, 2020 · 5 comments

Comments

@Vadorequest
Copy link

Hello @leerob, I've read your tutorial at https://leerob.io/blog/configuring-sentry-for-nextjs-apps (through https://forum.sentry.io/t/sentry-webpack-plugin-and-next-js-sourcemaps/4153/5)

I would love your help on UnlyEd/next-right-now#28

NRN is an OSS boilerplate, which features Sentry. But source maps don't work perfectly yet, I believe you could be quite helpful on this matter! 😉 (let me know if you have time and are willing to help!)

Thank you.

@leerob
Copy link
Owner

leerob commented Apr 3, 2020

Hey!

At first glance, nothing sticks out to me as wrong without diving in. If I have some time, I'll see if I can look at it.

Still waiting for this to abstract all these problems away -> https://github.com/zeit/next.js/tree/canary/packages/next-plugin-sentry

@Vadorequest
Copy link
Author

Thanks for taking a look!

I took a quick look at next-plugin-sentry and don't really see how it's gonna help with source maps, seems like some basic helper for logging errors.

@leerob
Copy link
Owner

leerob commented Apr 12, 2020

Gonna close this cause I doubt I'll be able to figure it out. Sentry setup is way too confusing with Next. Getting away from getInitialProps should help the Sentry setup a lot. Then there's a more clear separation of what's on the client and the server.

Ideally, this is all baked into the Sentry plugin, even source maps 👍

@leerob leerob closed this as completed Apr 12, 2020
@Vadorequest
Copy link
Author

Yeah, I agree with you... It's non-trivial. But it should be.

Getting away from getInitialProps should help the Sentry setup a lot.

Do you mean there is something going on that'll make it happen? Or is it just a thought of you?

@leerob
Copy link
Owner

leerob commented Apr 13, 2020

I'm just saying it reduces a lot of complexities that come from getInitialProps running on both client and server. This introduces a lot of edge cases into the Sentry set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants