Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search for movie/persons to navbar #297

Open
leepeuker opened this issue Apr 2, 2023 · 5 comments
Open

Add search for movie/persons to navbar #297

leepeuker opened this issue Apr 2, 2023 · 5 comments
Labels
enhancement New feature or request priority: high Very important

Comments

@leepeuker
Copy link
Owner

Currently it is not possible to directly search for a movie or a person from the navbar. This means you cannot reach the search from sites like the dashboard not at all, only the "Log play" button. Additionally there is no search yet which combines searching for movie/persons.

Todos:

  • add way to open search modal to navbar
  • build a search modal (integrate with current log play modal I guess?)
    • add option to search for movie or for a person
@leepeuker leepeuker added the enhancement New feature or request label Apr 6, 2023
@JVT038
Copy link
Collaborator

JVT038 commented Apr 18, 2023

Would this be done with a SQL query?
If so, wouldn't you need some complex query where you select with LIKE keyword and try to make some kind of join to search in multiple tables simultaneously?
I feel like this might result into slow searching, because there are easily hundreds or thousands of actors, and hundreds of movies in a database, and having to query multiple tables can impact performance negatively.
Maybe look into some specialized search engine like typesense or algolia for this stuff.

@leepeuker leepeuker added the priority: high Very important label Apr 22, 2023
@leepeuker
Copy link
Owner Author

leepeuker commented Apr 22, 2023

If so, wouldn't you need some complex query where you select with LIKE keyword and try to make some kind of join to search in multiple tables simultaneously?

Currently I am thinking about having just specific searches. So you cannot search for everything at once, you have to define what to search in (e.g. movies or persons or companies). That should make the search easier for us to implement and I do not really think that a global search is something people really need 🤔 For this sql performance should be more than enough

@leepeuker
Copy link
Owner Author

To be honest atm my main issue is that I still have no idea have the UI should look like

@JVT038
Copy link
Collaborator

JVT038 commented Jul 22, 2023

I'm currently just playing around with this function. Here's a small thingy I just made:

image

Searching for things would be on a separate page, instead of a modal, because I prefer to have a page dedicated to search.
The page can be accessed by clicking on the magnifying glass in the top-right corner, between the 'add movie' and the three dots button.

The search page itself has a select option, where the user can choose to either search for movies or for people and the user can run the query by clicking on the blue button on the right side.

@leepeuker
Copy link
Owner Author

leepeuker commented Jul 24, 2023

We will need more filters, like by year, rating, genre or language and sort options. Checkout the All movies site, there are some examples what we have to integrate into the global search. These options have to change to match the search type (person or movie) I think

I mean this page:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: high Very important
Projects
None yet
Development

No branches or pull requests

2 participants