-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TV shows #186
Comments
+1 would use it too! |
Hey, because this was asked at a few different places I have updated the README with an answer.
|
Would it be possible to keep this issue open with a "zero priority" label? This way interested folks can subscribe to the issue and get notified when the situation changes in the far future. |
Hey @iamkroot, I would prefer keeping this issue closed, I do not think that movary will ever support tv shows to be honest (it was planned and designed specifically for movies). |
Hey. I'm a PHP developer and I am willing to work on a PR that would add support for TV shows and music. I would probably fetch TV show info from TMDB (I think they have info about TV shows) and get music info from the free Spotify API. Besides that, I know Deezer, Musicbrainz and Genius have some pretty comprehensive publicly available APIs as well. Would you merge a PR that would add support for these things? |
Hey @JVT038 , that is great, you are welcome to contribute and every PR will be merged, which adds value to this project without increasing the technical dept to much. To your suggestions, my opinion is we should definitely forget about music and other media types for now, TV Show support alone will be enough work. If this is done we can think about supporting more media types. So when we focus on TV right now, the first question would be how can we best integrate this in the existing web UI, without losing the possibility to ignore TV shows if a user has no interest in it 🤔 As a starting point you could look into the |
The README sounds like a hard 'No' atm. Perhaps a mention in it saying 'any contribution's welcome' could open up the discussion a little? I must say that TV shows support is a must for me, although Movary seems really appealing. |
Yeah good point @Jucgshu , I have updated the readme like you suggested. Additionally I have reopend this ticket for more visibility. |
@JVT038 instead of tmdb I think tvdb is better for TV shows |
The TVDB costs €12,- per year. Source I don't think it's desirable to ask users to pay €12,- per year for an API while there are free alternatives (such as TMDB) |
@JVT038 can you not use a v4 API instead of every user using their own api? |
I don't know for sure, but I have a pretty strong feeling that we're going to violate their API ToS if I create a free developer API key and distribute that to everyone using Movary. |
@JVT038 how about a caching proxy? |
What do you mean with a caching proxy? |
@JVT038 using a caching proxy for example squid we can cache data from tvdb than use that data for movary. We won't be violating ToS. |
Would each user be running their own proxy or would there be a centralized proxy for all users? |
@JVT038 I am thinking that each user setup their own proxy connected to each other like p2p |
I think building a whole p2p system with trackers, announcers and everything like that, would be too much effort if the TMDB can also just be used without the whole p2p system. |
Like the look of this application myself, but yea until tv shows are supported I sadly have to pass this app up even though I would like another place to have all my movies/tv shows backuped up to. |
+1 On this! |
+1 for this feature.. |
+1 for this effort! |
+1 |
Apologies if they already are supported, I didn't see it mentioned in the README.
This is a feature request to support tracking TV show episode watches in addition to movies.
The text was updated successfully, but these errors were encountered: