Skip to content

Commit 8e41f67

Browse files
committed
Remove misc-include-cleaner suppression in util_tests.cpp
1 parent 29103af commit 8e41f67

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

.clang-tidy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,4 +86,4 @@ CheckOptions:
8686
- key: readability-identifier-length.MinimumParameterNameLength
8787
value: 1
8888
- key: misc-include-cleaner.IgnoreHeaders
89-
value: '(__chrono/.*)'
89+
value: '(__chrono/.*|stdlib\.h)'

modules/core/util/func_tests/util_tests.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ TEST(util_tests, check_unset_env) {
1010
#ifndef _WIN32
1111
int save_var = ppc::util::GetPPCNumThreads();
1212

13-
unsetenv("OMP_NUM_THREADS"); // NOLINT(concurrency-mt-unsafe,misc-include-cleaner)
13+
unsetenv("OMP_NUM_THREADS"); // NOLINT(concurrency-mt-unsafe)
1414

1515
EXPECT_EQ(ppc::util::GetPPCNumThreads(), 1);
1616

17-
setenv("OMP_NUM_THREADS", std::to_string(save_var).c_str(), 1); // NOLINT(concurrency-mt-unsafe,misc-include-cleaner)
17+
setenv("OMP_NUM_THREADS", std::to_string(save_var).c_str(), 1); // NOLINT(concurrency-mt-unsafe)
1818
#else
1919
GTEST_SKIP();
2020
#endif
@@ -25,12 +25,11 @@ TEST(util_tests, check_set_env) {
2525
int save_var = ppc::util::GetPPCNumThreads();
2626

2727
const int num_threads = static_cast<int>(std::thread::hardware_concurrency());
28-
// NOLINTNEXTLINE(concurrency-mt-unsafe,misc-include-cleaner)
29-
setenv("OMP_NUM_THREADS", std::to_string(num_threads).c_str(), 1);
28+
setenv("OMP_NUM_THREADS", std::to_string(num_threads).c_str(), 1); // NOLINT(concurrency-mt-unsafe)
3029

3130
EXPECT_EQ(ppc::util::GetPPCNumThreads(), num_threads);
3231

33-
setenv("OMP_NUM_THREADS", std::to_string(save_var).c_str(), 1); // NOLINT(concurrency-mt-unsafe,misc-include-cleaner)
32+
setenv("OMP_NUM_THREADS", std::to_string(save_var).c_str(), 1); // NOLINT(concurrency-mt-unsafe)
3433
#else
3534
GTEST_SKIP();
3635
#endif

0 commit comments

Comments
 (0)