Merge branch 'master' of https://github.com/learning-process/parallel_programming_course into an/convert_scripts

Author: allnes

.clang-tidy

@@ -1,6 +1,7 @@
 Checks: >
   bugprone-*,
   clang-diagnostic-*,
+  cppcoreguidelines-init-variables,
   llvm-include-order,
   llvm-namespace-comment,
   misc-*,
@@ -11,15 +12,13 @@ Checks: >
   -bugprone-casting-through-void,
   -bugprone-exception-escape,
   -bugprone-implicit-widening-of-multiplication-result,
-  -bugprone-narrowing-conversions,
   -misc-const-correctness,
   -misc-header-include-cycle,
   -misc-no-recursion,
   -misc-non-private-member-variables-in-classes,
   -misc-unused-parameters,
   -modernize-avoid-c-arrays,
   -modernize-loop-convert,
-  -modernize-use-nodiscard,
   -modernize-use-trailing-return-type,
   -readability-identifier-length,
   -readability-magic-numbers,

modules/ref/max_of_vector_elements/include/ref_task.hpp

@@ -27,8 +27,8 @@ class MaxOfVectorElements : public ppc::core::Task {
   }
 
   bool ValidationImpl() override {
-    bool is_count_values_correct;
-    bool is_count_indexes_correct;
+    bool is_count_values_correct = false;
+    bool is_count_indexes_correct = false;
     // Check count elements of output
     is_count_values_correct = task_data->outputs_count[0] == 1;
     is_count_indexes_correct = task_data->outputs_count[1] == 1;

modules/ref/min_of_vector_elements/include/ref_task.hpp

@@ -27,8 +27,8 @@ class MinOfVectorElements : public ppc::core::Task {
   }
 
   bool ValidationImpl() override {
-    bool is_count_values_correct;
-    bool is_count_indexes_correct;
+    bool is_count_values_correct = false;
+    bool is_count_indexes_correct = false;
     // Check count elements of output
     is_count_values_correct = task_data->outputs_count[0] == 1;
     is_count_indexes_correct = task_data->outputs_count[1] == 1;

modules/ref/most_different_neighbor_elements/func_tests/ref_tests.cpp

@@ -14,7 +14,7 @@ TEST(most_different_neighbor_elements, check_int32_t) {
   std::vector<int32_t> out(2, 0);
   std::vector<uint64_t> out_index(2, 0);
   for (size_t i = 0; i < in.size(); i++) {
-    in[i] = 2 * i;
+    in[i] = static_cast<int32_t>(2 * i);
   }
   in[234] = 0;
   in[235] = 4000;
@@ -68,7 +68,7 @@ TEST(most_different_neighbor_elements, check_double) {
   std::vector<double> out(2, 0);
   std::vector<uint64_t> out_index(2, 0);
   for (size_t i = 0; i < in.size(); i++) {
-    in[i] = i;
+    in[i] = static_cast<double>(i);
   }
   in[189] = -1000.1;
   in[190] = 9000.9;
@@ -177,7 +177,7 @@ TEST(most_different_neighbor_elements, check_float) {
   std::vector<float> out(2, 0.F);
   std::vector<uint64_t> out_index(2, 0);
   for (size_t i = 0; i < in.size(); i++) {
-    in[i] += (i + 1.F) * 2.5F;
+    in[i] += (static_cast<float>(i) + 1.F) * 2.5F;
   }
   in[0] = 110.001F;
   in[1] = -990.0025F;

modules/ref/nearest_neighbor_elements/func_tests/ref_tests.cpp

@@ -14,7 +14,7 @@ TEST(nearest_neighbor_elements, check_int32_t) {
   std::vector<int32_t> out(2, 0);
   std::vector<uint64_t> out_index(2, 0);
   for (size_t i = 0; i < in.size(); i++) {
-    in[i] = 2 * i;
+    in[i] = static_cast<int32_t>(2 * i);
   }
   in[234] = 0;
   in[235] = 1;
@@ -68,7 +68,7 @@ TEST(nearest_neighbor_elements, check_double) {
   std::vector<double> out(2, 0);
   std::vector<uint64_t> out_index(2, 0);
   for (size_t i = 0; i < in.size(); i++) {
-    in[i] = 2 * i;
+    in[i] = static_cast<double>(2 * i);
   }
   in[189] = 0.1;
   in[190] = 0.9;
@@ -177,7 +177,7 @@ TEST(nearest_neighbor_elements, check_float) {
   std::vector<float> out(2, 0.F);
   std::vector<uint64_t> out_index(2, 0);
   for (size_t i = 0; i < in.size(); i++) {
-    in[i] += (i + 1.F) * 2.5F;
+    in[i] += static_cast<float>(i + 1) * 2.5F;
   }
   in[0] = 0.001F;
   in[1] = 0.0025F;

modules/ref/sum_values_by_rows_matrix/func_tests/ref_tests.cpp

@@ -140,7 +140,7 @@ TEST(sum_values_by_rows_matrix, check_int64_t) {
   std::vector<uint64_t> in_index = {37, 38};
   std::vector<int64_t> out(37, 0);
   for (size_t i = 0; i < in.size(); ++i) {
-    in[i] = (i % 38) + 1;
+    in[i] = static_cast<int64_t>((i % 38) + 1);
   }
 
   // Create task_data

modules/ref/vector_dot_product/func_tests/ref_tests.cpp

@@ -15,8 +15,8 @@ TEST(vector_dot_product, check_int32_t) {
   std::vector<int32_t> in2(count_data, 1);
   std::vector<int32_t> out(1, 0);
   for (size_t i = 0; i < count_data; i++) {
-    in1[i] = i + 1;
-    in2[i] = i + 1;
+    in1[i] = static_cast<int32_t>(i + 1);
+    in2[i] = static_cast<int32_t>(i + 1);
   }
 
   // Create task_data
@@ -140,8 +140,8 @@ TEST(vector_dot_product, check_int64_t) {
   std::vector<int64_t> in2(count_data, 1);
   std::vector<int64_t> out(1, 0);
   for (uint64_t i = 0; i < count_data; i++) {
-    in1[i] = i + 1;
-    in2[i] = (i + 1) * (i + 1);
+    in1[i] = static_cast<int64_t>(i + 1);
+    in2[i] = static_cast<int64_t>((i + 1) * (i + 1));
   }
 
   // Create task_data

scoreboard/main.py

@@ -19,7 +19,7 @@
 
 print(directories)
 
-columns = ''.join(['<th colspan=4 style="text-align: center;">' + task_type + '</th>' for task_type in task_types])
+columns = ''.join(['<th colspan=5 style="text-align: center;">' + task_type + '</th>' for task_type in task_types])
 html_content = f"""
 <!DOCTYPE html>
 <html>
@@ -29,22 +29,30 @@
 </head>
 <body>
     <h1>Scoreboard</h1>
-    <p>S - Solution, P - Performance, O - Overdue, C - Cheating</p>
+    <p>
+        <b>(S)olution</b> - The correctness and completeness of the implemented solution.<br/>
+        <b>(A)cceleration</b> - The process of speeding up software to improve performance.
+        Speedup = T(seq) / T(parallel)<br/>
+        <b>(E)fficiency</b> - Optimizing software speed-up by improving CPU utilization and resource management.
+        Efficiency = Speedup / NumProcs * 100%<br/>
+        <b>(D)eadline</b> - The timeliness of the submission in relation to the given deadline.<br/>
+        <b>(P)lagiarism</b> - The originality of the work, ensuring no copied content from external sources.<br/>
+    </p>
     <table>
         <tr>
-            <th colspan=4>Tasks</th>
+            <th colspan=5>Tasks</th>
             {columns}
             <th>Total</th>
         </tr>
         <tr>
-            <th colspan=4></th>
-            {''.join(['<th>S</th><th>P</th><th>O</th><th>C</th>' for _ in range(len(task_types))])}
+            <th colspan=5></th>
+            {''.join(['<th>S</th><th>A</th><th>E</th><th>D</th><th>P</th>' for _ in range(len(task_types))])}
             <th></th>
         </tr>
 """
 
 for dir in directories:
-    html_content += f"<tr><td colspan=4>{dir}</td>"
+    html_content += f"<tr><td colspan=5>{dir}</td>"
     total_count = 0
     for task_type in task_types:
         if directories[dir].get(task_type) == "done":
@@ -54,7 +62,8 @@
             html_content += '<td style="text-align: center;background-color: lightblue;">1</td>'
             total_count += 1
         else:
-            html_content += "<td>0</td>"
+            html_content += '<td style="text-align: center;">0</td>'
+        html_content += '<td style="text-align: center;">0</td>'
         html_content += '<td style="text-align: center;">0</td>'
         html_content += '<td style="text-align: center;">0</td>'
         html_content += '<td style="text-align: center;">0</td>'