Skip to content

Commit 6c1e33c

Browse files
authored
Fix test for unset PPC_NUM_THREADS environment variable (#461)
Get rid of concurrent writing by multiple threads
1 parent e8c853a commit 6c1e33c

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

modules/core/util/tests/util.cpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
#include <gtest/gtest.h>
44

5+
#include <libenvpp/detail/get.hpp>
56
#include <string_view>
67

78
#include "omp.h"
@@ -16,14 +17,9 @@ TEST(util_tests, extracts_correct_namespace) {
1617
}
1718

1819
TEST(util_tests, threads_control_check_openmp_disabled_valgrind) {
19-
int ppc_num_threads = ppc::util::GetNumThreads();
20+
const auto num_threads_env_var = env::get<int>("PPC_NUM_THREADS");
2021

21-
int omp_num_threads = -1;
22-
#pragma omp parallel default(none) shared(omp_num_threads) num_threads(ppc::util::GetNumThreads())
23-
omp_num_threads = omp_get_num_threads();
24-
25-
// Check Result
26-
ASSERT_EQ(ppc_num_threads, omp_num_threads);
22+
EXPECT_EQ(ppc::util::GetNumThreads(), omp_get_max_threads());
2723
}
2824

2925
namespace test_ns {

0 commit comments

Comments
 (0)