Fixed multiple warnings

Author: zorba80

contracts/asserter/asserter.cpp

@@ -11,7 +11,7 @@ static int global_variable = 45;
 
 extern "C" {
     /// The apply method implements the dispatch of events to this contract
-    void apply( uint64_t receiver, uint64_t code, uint64_t action ) {
+   void apply( uint64_t /* receiver */, uint64_t code, uint64_t action ) {
        require_auth(code);
        if( code == N(asserter) ) {
           if( action == N(procassert) ) {

contracts/eosio.bios/eosio.bios.hpp

@@ -15,7 +15,7 @@ namespace eosio {
 
          void setalimits( account_name account, uint64_t ram_bytes, uint64_t net_weight, uint64_t cpu_weight ) {
             require_auth( _self );
-            set_resource_limits( account, ram_bytes, net_weight, cpu_weight );
+            set_resource_limits( account, (int64_t)ram_bytes, (int64_t)net_weight, (int64_t)cpu_weight );
          }
 
          void setglimits( uint64_t ram, uint64_t net, uint64_t cpu ) {

contracts/eosio.system/delegate_bandwidth.cpp

@@ -169,7 +169,7 @@ namespace eosiosystem {
           tokens_out = es.convert( asset(bytes,S(0,RAM)), CORE_SYMBOL);
       });
 
-      _gstate.total_ram_bytes_reserved -= bytes;
+      _gstate.total_ram_bytes_reserved -= static_cast<decltype(_gstate.total_ram_bytes_reserved)>(bytes); // bytes > 0 is asserted above
       _gstate.total_ram_stake          -= tokens_out.amount;
 
       //// this shouldn't happen, but just in case it does we should prevent it
@@ -190,7 +190,6 @@ namespace eosiosystem {
    }
 
    void validate_b1_vesting( int64_t stake ) {
-      const int64_t seconds_per_year = 60*60*24*365;
       const int64_t base_time = 1527811200; /// 2018-06-01
       const int64_t max_claimable = 100'000'000'0000ll;
       const int64_t claimable = int64_t(max_claimable * double(now()-base_time) / (10*seconds_per_year) );

contracts/eosio.system/voting.cpp

@@ -100,7 +100,7 @@ namespace eosiosystem {
       bytes packed_schedule = pack(producers);
 
       if( set_proposed_producers( packed_schedule.data(),  packed_schedule.size() ) >= 0 ) {
-         _gstate.last_producer_schedule_size = top_producers.size();
+         _gstate.last_producer_schedule_size = static_cast<decltype(_gstate.last_producer_schedule_size)>( top_producers.size() );
       }
    }
 

contracts/exchange/exchange.cpp

@@ -112,7 +112,7 @@ namespace eosio {
 
    void exchange::createx( account_name    creator,
                  asset           initial_supply,
-                 uint32_t        fee,
+                 uint32_t        /* fee */,
                  extended_asset  base_deposit,
                  extended_asset  quote_deposit
                ) {

contracts/multi_index_test/multi_index_test.cpp

@@ -168,7 +168,7 @@ struct limit_order {
 namespace multi_index_test {
    extern "C" {
       /// The apply method implements the dispatch of events to this contract
-      void apply( uint64_t receiver, uint64_t code, uint64_t action ) {
+      void apply( uint64_t /* receiver */, uint64_t code, uint64_t action ) {
          require_auth(code);
          eosio_assert(eosio::dispatch<multi_index_test, multi_index_test::trigger>(code, action),
                       "Could not dispatch");

contracts/proxy/proxy.cpp

@@ -33,7 +33,7 @@ namespace proxy {
    };
 
    template<typename T>
-   void apply_transfer(uint64_t receiver, account_name code, const T& transfer) {
+   void apply_transfer(uint64_t receiver, account_name /* code */, const T& transfer) {
       config code_config;
       const auto self = receiver;
       auto get_res = configs::get(code_config, self);

contracts/test_api/test_datastream.cpp

@@ -1,6 +1,7 @@
 
 #include <eosiolib/eosio.hpp>
 #include <eosiolib/datastream.hpp>
+#include <cmath>
 
 #include "test_api.hpp"
 
@@ -17,6 +18,32 @@ struct testtype {
     }
 };
 
+template <>
+struct testtype<double> {
+   static void run(const double &v, const char *errmsg = "") {
+      char buf[128];
+      eosio::datastream<char *> ds(buf, sizeof(buf));
+      ds << v;
+      double v2;
+      ds.seekp(0);
+      ds >> v2;
+      eosio_assert(std::abs(v - v2) < 1e-20, errmsg);
+   }
+};
+
+template <>
+struct testtype<float> {
+   static void run(const float &v, const char *errmsg = "") {
+      char buf[128];
+      eosio::datastream<char *> ds(buf, sizeof(buf));
+      ds << v;
+      float v2;
+      ds.seekp(0);
+      ds >> v2;
+      eosio_assert(std::abs(v - v2) < float(1e-10), errmsg);
+   }
+};
+
 void test_datastream::test_basic()
 {
 
@@ -28,7 +55,7 @@ void test_datastream::test_basic()
     testtype<unsigned short>::run(12345, "uint16");
     testtype<int>::run(-1234567890, "int32");
     testtype<unsigned int>::run(3234567890u, "uint32");
-    testtype<long long>::run(0x8000000000000000ull, "int64");
+    testtype<long long>::run((long long)0x8000000000000000ll, "int64");
     testtype<unsigned long long>::run(0x7fffffffffffffffull, "uint64");
     testtype<float>::run(1.234f, "float");
     testtype<double>::run(0.333333333333333333, "double");
@@ -39,15 +66,15 @@ void test_datastream::test_basic()
     struct Pair {
         int a;
         double d;
-        bool operator==(const Pair &p) const { return a == p.a && d == p.d;} 
+          bool operator==(const Pair &p) const { return a == p.a && std::abs(d - p.d) < 1e-20;} 
     };
     testtype<Pair>::run({1, 1.23456}, "struct");
 
     struct StaticArray {
         int a[2];
         bool operator==(const StaticArray &o) const { return a[0] == o.a[0] && a[1] == o.a[1]; }
     };
-    testtype<StaticArray>::run({10,20}, "staticArray");
+    testtype<StaticArray>::run({10,20}, "StaticArray");
 
     testtype<std::string>::run("hello", "string");
 

contracts/test_api/test_permission.cpp

@@ -58,7 +58,7 @@ struct test_permission_last_used_msg {
    EOSLIB_SERIALIZE( test_permission_last_used_msg, (account)(permission)(last_used_time) )
 };
 
-void test_permission::test_permission_last_used(uint64_t receiver, uint64_t code, uint64_t action) {
+void test_permission::test_permission_last_used(uint64_t /* receiver */, uint64_t code, uint64_t action) {
    (void)code;
    (void)action;
    using namespace eosio;
@@ -68,7 +68,7 @@ void test_permission::test_permission_last_used(uint64_t receiver, uint64_t code
    eosio_assert( get_permission_last_used(params.account, params.permission) == params.last_used_time, "unexpected last used permission time" );
 }
 
-void test_permission::test_account_creation_time(uint64_t receiver, uint64_t code, uint64_t action) {
+void test_permission::test_account_creation_time(uint64_t /* receiver */, uint64_t code, uint64_t action) {
    (void)code;
    (void)action;
    using namespace eosio;

contracts/test_api/test_transaction.cpp

@@ -274,7 +274,7 @@ void test_transaction::send_deferred_tx_with_dtt_action() {
 void test_transaction::cancel_deferred_transaction_success() {
    using namespace eosio;
    auto r = cancel_deferred( 0xffffffffffffffff ); //use the same id (0) as in send_deferred_transaction
-   eosio_assert( r, "transaction was not found" );
+   eosio_assert( (bool)r, "transaction was not found" );
 }
 
 void test_transaction::cancel_deferred_transaction_not_found() {
@@ -310,9 +310,9 @@ void test_transaction::context_free_api() {
 
 extern "C" { int is_feature_active(int64_t); }
 void test_transaction::new_feature() {
-   eosio_assert(false == is_feature_active(N(newfeature)), "we should not have new features unless hardfork");
+   eosio_assert(false == is_feature_active((int64_t)N(newfeature)), "we should not have new features unless hardfork");
 }
 
 void test_transaction::active_new_feature() {
-   activate_feature(N(newfeature));
+   activate_feature((int64_t)N(newfeature));
 }

contracts/test_api_db/test_db.cpp

@@ -159,7 +159,7 @@ void test_db::primary_i64_general(uint64_t receiver, uint64_t code, uint64_t act
 
       buffer_len = 20;
       len = db_get_i64(itr, value, 0);
-      len = db_get_i64(itr, value, len);
+      len = db_get_i64(itr, value, (uint32_t)len);
       value[len] = '\0';
       std::string sfull(value);
       eosio_assert(sfull == "bob's info", "primary_i64_general - db_get_i64 - full");
@@ -448,7 +448,7 @@ void test_db::test_invalid_access(uint64_t receiver, uint64_t code, uint64_t act
    uint64_t pk    = scope;
 
    int32_t itr = -1;
-   uint64_t value;
+   uint64_t value = 0;
    switch( ia.index ) {
       case 1:
          itr = db_idx64_find_primary(ia.code, scope, table, &value, pk);
@@ -536,7 +536,7 @@ void test_db::idx_double_nan_lookup_fail(uint64_t receiver, uint64_t, uint64_t)
    }
 }
 
-void test_db::misaligned_secondary_key256_tests(uint64_t receiver, uint64_t, uint64_t) {
+void test_db::misaligned_secondary_key256_tests(uint64_t /* receiver */, uint64_t, uint64_t) {
    auto key = eosio::key256::make_from_word_sequence<uint64_t>(0ULL, 0ULL, 0ULL, 42ULL);
    char* ptr = (char*)(&key);
    ptr += 1;

contracts/test_api_mem/test_extended_memory.cpp

@@ -90,7 +90,7 @@ void test_extended_memory::test_page_memory_exceeded() {
 }
 
 void test_extended_memory::test_page_memory_negative_bytes() {
-   eosio_assert(reinterpret_cast<int32_t>(sbrk(-1)) == -1, "Should have errored for trying to remove memory");
+   eosio_assert(reinterpret_cast<int32_t>(sbrk((uint32_t)-1)) == -1, "Should have errored for trying to remove memory");
 }
 
 void test_extended_memory::test_initial_buffer() {

libraries/chain/eosio_contract.cpp

@@ -146,7 +146,7 @@ void apply_eosio_setcode(apply_context& context) {
 
    db.modify( account, [&]( auto& a ) {
       /** TODO: consider whether a microsecond level local timestamp is sufficient to detect code version changes*/
-      #warning TODO: update setcode message to include the hash, then validate it in validate
+      // TODO: update setcode message to include the hash, then validate it in validate
       a.last_code_update = context.control.pending_block_time();
       a.code_version = code_id;
       a.code.resize( code_size );

plugins/chain_plugin/chain_plugin.cpp

@@ -140,7 +140,7 @@ void chain_plugin::set_program_options(options_description& cli, options_descrip
           "Contract account added to contract blacklist (may specify multiple times)")
          ;
 
-#warning TODO: rate limiting
+// TODO: rate limiting
          /*("per-authorized-account-transaction-msg-rate-limit-time-frame-sec", bpo::value<uint32_t>()->default_value(default_per_auth_account_time_frame_seconds),
           "The time frame, in seconds, that the per-authorized-account-transaction-msg-rate-limit is imposed over.")
          ("per-authorized-account-transaction-msg-rate-limit", bpo::value<uint32_t>()->default_value(default_per_auth_account),

unittests/bootseq_tests.cpp

@@ -332,7 +332,7 @@ BOOST_FIXTURE_TEST_CASE( bootseq_test, bootseq_tester ) {
         votepro( N(minow1), {N(p1), N(p2)} );
 
 
-#warning Complete this test
+// TODO: Complete this test
     } FC_LOG_AND_RETHROW()
 }
 

unittests/resource_limits_test.cpp

@@ -140,7 +140,7 @@ BOOST_AUTO_TEST_SUITE(resource_limits_test)
     */
 
 
-#warning restore weighted capacity cpu tests
+// TODO: restore weighted capacity cpu tests
 #if 0
    BOOST_FIXTURE_TEST_CASE(weighted_capacity_cpu, resource_limits_fixture) try {
       const vector<int64_t> weights = { 234, 511, 672, 800, 1213 };

unittests/wasm_tests.cpp

@@ -589,7 +589,7 @@ BOOST_FIXTURE_TEST_CASE(cpu_usage_tests, tester ) try {
 
 // test weighted cpu limit
 BOOST_FIXTURE_TEST_CASE(weighted_cpu_limit_tests, tester ) try {
-#warning This test does not appear to be very robust.
+// TODO This test does not appear to be very robust.
    resource_limits_manager mgr = control->get_mutable_resource_limits_manager();
    create_accounts( {N(f_tests)} );
    create_accounts( {N(acc2)} );
@@ -1713,7 +1713,7 @@ BOOST_FIXTURE_TEST_CASE( fuzz, TESTER ) try {
 } FC_LOG_AND_RETHROW()
 
 
-#warning restore net_usage_tests
+// TODO: restore net_usage_tests
 #if 0
 BOOST_FIXTURE_TEST_CASE(net_usage_tests, tester ) try {
    int count = 0;