Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md parameter of whnf' is unused #55

Closed
dwrensha opened this issue Jun 22, 2022 · 2 comments · Fixed by #56
Closed

md parameter of whnf' is unused #55

dwrensha opened this issue Jun 22, 2022 · 2 comments · Fixed by #56

Comments

@dwrensha
Copy link
Member

In the MetaM chapter, whnf' has an unused md parameter:

https://github.com/arthurpaulino/lean4-metaprogramming-book/blob/b7762483d16577eb2f25d6a57942f76054acb578/lean/main/metam.lean#L621-L625

It looks to me like this should be removed.

Lower down, the transparency mode is controlled via withTransparency:

https://github.com/arthurpaulino/lean4-metaprogramming-book/blob/b7762483d16577eb2f25d6a57942f76054acb578/lean/main/metam.lean#L647

cc @JLimperg, who added this section as part of #34.
@arthurpaulino
Copy link
Collaborator

Yes we can remove it. @dwrensha do you want to make the PR?

@dwrensha dwrensha mentioned this issue Jun 22, 2022
Merged
@JLimperg
Copy link
Contributor

Indeed this was left over from an earlier version of the text. Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove unused parameter from whnf' dwrensha/lean4-metaprogramming-book
3 participants
@dwrensha @JLimperg @arthurpaulino