Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Metalmind Selection Code #99

Open
5 tasks
leafreynolds opened this issue Mar 21, 2024 · 2 comments
Open
5 tasks

Refactor Metalmind Selection Code #99

leafreynolds opened this issue Mar 21, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@leafreynolds
Copy link
Owner

The code that chooses what Metalmind to tap/store is one of the oldest pieces of code in the project, and likely needs a refactor to improve performance and be more intelligent about what order the metalminds will show in.

  • Improve performance
  • Improve Metalmind selection order (Hotbar, Curios, armor, inventory)
  • Config values for the above to change order

While we are in the area, we should:

  • Fix bug that leaves only a few points left in a metalmind
  • Allow grabbing points from multiple metalminds at once as part of one request (which may fix the above)
@leafreynolds leafreynolds added bug Something isn't working enhancement New feature or request labels Mar 21, 2024
@leafreynolds leafreynolds added this to the Feruchemy milestone Mar 21, 2024
@R0b0r0b
Copy link

R0b0r0b commented Mar 21, 2024

Ooh, I never thought to say - I think I found a solution to the bug where a few points were left - all you need to do is tap or store at level one, depending on whether you're filling or storing.

I'm still open to a proper solution, though, especially as this workaround doesn't work for copper.

@MoonlitJolteon
Copy link
Collaborator

MoonlitJolteon commented Mar 22, 2024

May be worth taking a look at Hexcasting and media works for reference, Hexcasting has to deal with finding media (amethyst and related) in the inventory, and media works implements a better algorithm for the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants