Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hemalurgy] Non-Power Spikes from loot chests have no hemalurgic investment #61

Open
leafreynolds opened this issue Nov 23, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@leafreynolds
Copy link
Owner

Issue description

InvestSpikeLootFunction.java currently is set up to only invest power spikes. I currently just throw up an error instead for non-power spikes.

We need to update that so that non-power spikes have an appropriately hemalurgically decayed amount of bonus.

Steps to reproduce

Spawn a bunch of loot chests, starter chest has a 50/50 chance of containing a spike
/setblock ~ ~1 ~ minecraft:chest{LootTable:"minecraft:chests/spawn_bonus_chest"}

Repeat several times until observing a non power spike.

Observe that iron, tin and other non-power based spikes have no hemalurgic investment.

Minecraft version

1.19.2 (Latest)

Forge version

43.1.3

Cosmere version

Latest

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response

@leafreynolds leafreynolds added bug Something isn't working good first issue Good for newcomers labels Nov 23, 2023
@leafreynolds leafreynolds added this to the Hemalurgy milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

1 participant