Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmere] Refactor power granting code #136

Open
leafreynolds opened this issue Jan 8, 2025 · 0 comments
Open

[Cosmere] Refactor power granting code #136

leafreynolds opened this issue Jan 8, 2025 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@leafreynolds
Copy link
Owner

Currently the cosmere library mod handles granting powers, even though it doesn't properly know what allomancy/feruchemy etc is.

We should refactor things so that it's the sub mods themselves that grant the powers. This is a little more complicated because there's lore related rules to what powers can't be granted with other powers, like mistborn and full feruchemist.

Proposed changes:
We set up events for when powers are needing to be granted:

  • onGrantStartingPowers
  • onBreedGrantPowers
  • etc

and then have those events track:

  • whether a listener has said yes I wanna give powers.
  • what powers it wants to give
  • And whether that listener says other powers are blacklisted from being granted with it (mistborn/feruchemist)

The event should then take all that information and then decide resolve the granting of powers using that information.

@leafreynolds leafreynolds added the enhancement New feature or request label Jan 8, 2025
@leafreynolds leafreynolds added this to the Cosmere milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant